From 5d64057555a1d09d8243d2da72a6c5a767284ef0 Mon Sep 17 00:00:00 2001 From: Josh Goebel Date: Mon, 25 Apr 2022 10:31:49 -0400 Subject: [PATCH] Main sources should properly require dependencies Creating this largely as a discussion topic (since issues aren't open). Can dependencies please be handled properly such that using this from `nodejs` "just works" - like with every NPM libraries - ie, libraries (in raw form) should require their own dependencies... Users should not be forced to rely on globals just to use the library from Node proper. I do think the final distributable would be improved if it also bundled `colorparsley` (a tiny dependency) rather than forcing client-side users to deal with dependency hell, but that's a secondary issue. --- Also: Can the fact that this is a template repo be fixed and could issues be opposed to allow people to file issues? --- src/apca-w3.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/apca-w3.js b/src/apca-w3.js index 5aa4724..275d3ba 100644 --- a/src/apca-w3.js +++ b/src/apca-w3.js @@ -28,6 +28,8 @@ // */ /////////////////////////////////////////////////////////////////////////////// +const { colorParsley } = require("colorparsley") + // ==ClosureCompiler== // @compilation_level SIMPLE_OPTIMIZATIONS // @output_file_name apca-w3.min.js