Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail to build for armhf #505

Closed
marillat opened this issue Feb 26, 2022 · 0 comments · May be fixed by #507
Closed

Fail to build for armhf #505

marillat opened this issue Feb 26, 2022 · 0 comments · May be fixed by #507
Assignees
@bennettpeter

Comments

@marillat
Copy link

Debian armhf unstable

commit 75cf504 is not enough to fix the arm CPU detection.
The main configure use the same broken detection. Applying the same patch fix this issue.

--- a/configure
+++ b/configure
@@ -4308,9 +4308,10 @@ elif enabled arm; then
         fi
     }
 
-    [ "$cpu" = generic ] && cpu=$(probe_arm_arch)
-
     case $cpu in
+        generic)
+            subarch=$(probe_arm_arch | sed 's/[^a-z0-9]//g')
+        ;;
         armv*)
             cpuflags="-march=$cpu"
             subarch=$(echo $cpu | sed 's/[^a-z0-9]//g')
@bennettpeter bennettpeter self-assigned this Feb 26, 2022
bennettpeter added a commit that referenced this issue Feb 26, 2022
@bennettpeter
Fix CPU detection for armhf
75b942f 
This applies the same fix in MythTV as was applied in 75cf504 to FFmpeg.
The same code is in MythTV and needs the same fix.

Fixes #505

(cherry picked from commit 13e75f1)
@ulmus-scott ulmus-scott mentioned this issue Feb 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bennettpeter bennettpeter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

configure: fix --cpu=host for Intel Celeron and Pentium ulmus-scott/mythtv
2 participants
@marillat @bennettpeter