branch-fixes/34 doesn't compile with libx265 v4

[hamelg]

• Platform:
  a uptodate Archlinux
• MythTV version:
  34
• Package version:
  mythtv-git 34.0.r30.gc376437559-1

When building mythv, the compilation fails with this error :

libavcodec/libx265.c: In function ‘libx265_encode_frame’:
libavcodec/libx265.c:579:59: error: passing argument 5 of ‘ctx->api->encoder_encode’ from incompatible pointer type [-Wincompatible-pointer-types]
  579 |                                    pic ? &x265pic : NULL, &x265pic_out);
      |                                                           ^~~~~~~~~~~~
      |                                                           |
      |                                                           x265_picture *
libavcodec/libx265.c:579:59: note: expected ‘x265_picture **’ but argument is of type ‘x265_picture *’
CC      libavcodec/mjpegbdec.o
make[2]: *** [ffbuild/common.mak:81: libavcodec/libx265.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/goinfre/build/arch/mythtv-git/src/mythtv/mythtv/external/FFmpeg'
make[1]: *** [Makefile:32: FFmpeg-all] Error 2
make[1]: Leaving directory '/goinfre/build/arch/mythtv-git/src/mythtv/mythtv/external'
make: *** [Makefile:66: external] Error 2
==> ERROR: A failure occurred in build().
    Aborting...

[hamelg]

This error occurs after upgrading libx265 dependency from 3.6 to 4.0.

[ulmus-scott]

I suspect you will need FFmpeg/FFmpeg@1f801df and FFmpeg/FFmpeg@099f88b

[hamelg]

thanks !
at now we use libx265.so.212, FFmpeg/FFmpeg@1f801df should be enough.