Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Implement updated Page header / nav #1137

Open
3 tasks
aboydnw opened this issue Aug 29, 2024 · 4 comments · May be fixed by #1247
Open
3 tasks

[Refactor] Implement updated Page header / nav #1137

aboydnw opened this issue Aug 29, 2024 · 4 comments · May be fixed by #1247
Assignees
Labels
veda v2 VEDA Refactor Epic Work

Comments

@aboydnw
Copy link
Contributor

aboydnw commented Aug 29, 2024

Context

This ticket is for a layout component as part of the VEDA refactor. This components are used to generate the overall layout and site architecture of the Dashboard. They match the overall look and feel of the app and will be used in the template instance. Our recommendation will be to use these layout components, and we anticipate that most instances will use these components, but some may decide to bring their own.

Navigation relates to the top level nav, but also any side navigation, or sub navigation found in the dataset overview page or other pages. This also depends on the design ticket #1123

This ticket might be broken down into smaller tickets after initial investigation.

Notes:

  • Mark new files for VEDA2 refactor with @VEDA2-REFACTOR-WORK

Acceptance Criteria:

  • Instances are able to pull in the page header component into their existing sites
  • Instances can add whatever nav links they need, in whatever order
  • The updated page header uses USWDS components and styling

Related to: #1193

@aboydnw aboydnw added the veda v2 VEDA Refactor Epic Work label Aug 29, 2024
@aboydnw aboydnw changed the title [Refactor] Layout Components - Navigation [Refactor] Adjust nav, header, and logo as needed based on template instance designs Oct 14, 2024
@aboydnw
Copy link
Contributor Author

aboydnw commented Oct 14, 2024

updating based on comment in #1136

@sandrahoang686 sandrahoang686 changed the title [Refactor] Adjust nav, header, and logo as needed based on template instance designs [Refactor] Implement new design of Page Header and logo as needed based on template instance designs Oct 21, 2024
@sandrahoang686
Copy link
Collaborator

@faustoperez @aboydnw could we also make sure to specify in these implementation or design tickets what we expect to see in the current instances alongside the template instance. As per our discussion this past Tuesday. Since again this is a "refactor" still so we need to know if the new template designs are okay being implemented and used in current instances too - more so the uswds components part and void of stuff like theming and color. This would be really helpful in helping us understand how to build certain components (either a fork or with existing components).

for example:
Page header to be implemented in template design looks like... Currently existing page header is okay to adopt this new design but maintains the same color/themes (design would be helpful for current too)

Do you think you could specify these in these tickets and in the design work?

@aboydnw aboydnw changed the title [Refactor] Implement new design of Page Header and logo as needed based on template instance designs [Refactor] Implement updated Page header / nav Nov 1, 2024
@aboydnw
Copy link
Contributor Author

aboydnw commented Nov 1, 2024

Pasting here the outcome of the discussion in slack, for posterity

Our default is that we implement new designs in existing components, instead of forking. So as we release these updated components, existing instances will see small stylistic changes if they uptake the latest version of veda-ui.

This might result in some small stylistic changes to components like the nav, footer, and others, and they might differ slightly from other features that don’t yet use USWDS styling, like the Data Catalog. Over time, all features will be updated to match USWDS styling, but that will take some time. So, instead of managing multiple forks for an extended period, we’d be better off accepting the differences.

@sandrahoang686 sandrahoang686 self-assigned this Nov 4, 2024
@AliceR AliceR linked a pull request Nov 11, 2024 that will close this issue
4 tasks
@sandrahoang686
Copy link
Collaborator

Screenshot 2024-11-12 at 12 18 17

Spoke with @faustoperez related to the secondary menu items and the differences between the design and what uswds offers and how to move forward from here..
Fausto mentioned it is okay to move forward with the separators and making the Contact us button into a link cc @AliceR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
veda v2 VEDA Refactor Epic Work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants