-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Implement updated Page header / nav #1137
Comments
updating based on comment in #1136 |
@faustoperez @aboydnw could we also make sure to specify in these implementation or design tickets what we expect to see in the current instances alongside the template instance. As per our discussion this past Tuesday. Since again this is a "refactor" still so we need to know if the new template designs are okay being implemented and used in current instances too - more so the uswds components part and void of stuff like theming and color. This would be really helpful in helping us understand how to build certain components (either a fork or with existing components). for example: Do you think you could specify these in these tickets and in the design work? |
Pasting here the outcome of the discussion in slack, for posterity
|
Spoke with @faustoperez related to the secondary menu items and the differences between the design and what uswds offers and how to move forward from here.. |
Context
This ticket is for a layout component as part of the VEDA refactor. This components are used to generate the overall layout and site architecture of the Dashboard. They match the overall look and feel of the app and will be used in the template instance. Our recommendation will be to use these layout components, and we anticipate that most instances will use these components, but some may decide to bring their own.
Navigation relates to the top level nav, but also any side navigation, or sub navigation found in the dataset overview page or other pages. This also depends on the design ticket #1123
This ticket might be broken down into smaller tickets after initial investigation.
Notes:
@VEDA2-REFACTOR-WORK
Acceptance Criteria:
Related to: #1193
The text was updated successfully, but these errors were encountered: