You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are a few outstanding comments from #78 that are being moved to a new issue so that we can try to get the basic timeseries functionality merged in. Please see that PR for more details/context on these comments!
From @wwieder , "I wonder if a more generic approach [than using lev] may be to copy all the coordinate dimensions from a history file onto the single variable time series?"
Ensure code is generic enough for different history file types (e.g. patch or landunit level output from CLM, as opposed to grid cell averages)
vars_to_derive might be updated when Sympy derived quantities from string equations ADF#278 comes in. From @nusbaume, "we could potentially use the sympy package to allow users to write their own equations for derived variables without having to write new python code for each individual derived quantity."
from @TeaganKing, "Each component will need to adjust the variables they want to generate (unless processing all vars), the relevant history string, and the height dimension they are using (lev is currently the default) in config.yml.
Process_all should be updated; I think there's some issue going on with vars not being available in all files; this might have to do with needing to change hist_string.
We also want to include an alternative to num_procs so that we don't surprise (especially non-NCAR) users with a somewhat hidden request for a particular number of processors
In order to manage which timeseries scripts we run (for which components), we can use the compute_scripts feature. This will also allow us to specify that timeseries should be run first. For details, see comments from @rmshkv in API updates to specify components #88 and Add single-variable time series file generation function from ADF #78. @mnlevy1981 and I had also discussed including a --timeseries-only flag in order to run timeseries without running the notebooks, and renaming --timeseries to --timeseries-first to be clear that that particular flag is for running timeseries AND diagnostics notebooks. However, I think that the using the compute_scripts ploomber capabilities would be ideal in this case.
Include **timeseries_params and use something like if type(arg1) == str: arg1 = [arg1] in timeseries.py instead of run.py in order to implement kwargs.
from @wwieder Can we include additional data for some components? For example having the information about area and landfrac makes calculating global or regional sums easier.
The text was updated successfully, but these errors were encountered:
There are a few outstanding comments from #78 that are being moved to a new issue so that we can try to get the basic timeseries functionality merged in. Please see that PR for more details/context on these comments!
lev
] may be to copy all the coordinate dimensions from a history file onto the single variable time series?"vars_to_derive
might be updated when Sympy derived quantities from string equations ADF#278 comes in. From @nusbaume, "we could potentially use thesympy
package to allow users to write their own equations for derived variables without having to write new python code for each individual derived quantity."lev
is currently the default) inconfig.yml
.Process_all
should be updated; I think there's some issue going on with vars not being available in all files; this might have to do with needing to changehist_string
.num_procs
so that we don't surprise (especially non-NCAR) users with a somewhat hidden request for a particular number of processorscompute_scripts
feature. This will also allow us to specify that timeseries should be run first. For details, see comments from @rmshkv in API updates to specify components #88 and Add single-variable time series file generation function from ADF #78. @mnlevy1981 and I had also discussed including a--timeseries-only
flag in order to run timeseries without running the notebooks, and renaming--timeseries
to--timeseries-first
to be clear that that particular flag is for running timeseries AND diagnostics notebooks. However, I think that the using thecompute_scripts
ploomber capabilities would be ideal in this case.**timeseries_params
and use something likeif type(arg1) == str: arg1 = [arg1]
intimeseries.py
instead ofrun.py
in order to implement kwargs.area
andlandfrac
makes calculating global or regional sums easier.The text was updated successfully, but these errors were encountered: