Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post capgen unification: pylint code #547

Open
climbfuji opened this issue Mar 8, 2024 · 3 comments
Open

Post capgen unification: pylint code #547

climbfuji opened this issue Mar 8, 2024 · 3 comments

Comments

@climbfuji
Copy link
Collaborator

Description

As of 2024-03-08:

> cd test
> ./pylint_test.sh
...
------------------------------------------------------------------
Your code has been rated at 8.48/10 (previous run: 8.48/10, +0.00)

This is likely going to change while we transition from prebuild to capgen and add, remove, modify features.

Solution

Fix coding style after capgen unification

Alternatives (optional)

Leave as is - not a good idea

Related to (optional)

n/a

@nusbaume
Copy link
Collaborator

It would be great too to make a Github Action that automatically runs pylint against the relevant files and fails if the score is below some threshold. Although if there is interest then it should probably be done after pylint_test.sh produces good scores, or else the test will constantly fail.

@climbfuji
Copy link
Collaborator Author

Also, we don't have to use pylint. There are other utilities like pycodestyle and black.

@mkavulich
Copy link
Collaborator

@nusbaume Rather than have a specific threshold I wonder if it would be possible to just not allow the pylint score to decrease? That way we're either doing no harm, or improving things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants