Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize ordering of ccpp_error_code and ccpp_error_message #574

Open
peverwhee opened this issue Jul 1, 2024 · 2 comments
Open

Standardize ordering of ccpp_error_code and ccpp_error_message #574

peverwhee opened this issue Jul 1, 2024 · 2 comments

Comments

@peverwhee
Copy link
Collaborator

Description

The framework sometimes uses "errcode, errmsg" in the calling list and sometimes has "errmsg, errcode". It would be nice if this was consistent.

The NCAR SEs are leaning towards "errcode, errmsg", but are happy either way.

Solution

Modify all calling lists (in generated code and in static src code) to adhere to ordering we decide.

@climbfuji
Copy link
Collaborator

climbfuji commented Jul 3, 2024

In the UFS, it's consistently errmsg, errflg

Example: https://github.com/ufs-community/ccpp-physics/blob/ufs/dev/physics/CONV/Grell_Freitas/cu_gf_driver.F90

@peverwhee
Copy link
Collaborator Author

@DomHeinzeller OK, sounds like it'll be easiest to keep it in that order for the framework then. That's fine by me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants