Add more wildcard characters to filenames and add soil color to LSM IC #419
Conversation
bluefinweiwei
commented
Dec 15, 2023
•
bluefinweiwei
commented
- Add wildcard characters * for various output filenames, e.g., gfs.t00z.atmf0000.nc, gfs.t00z.sfcf0000.nc, oro_C96.mx100.tile1.nc.
- Add soil color (a new soil property in Noah-MP) to get LSM IC set correctly, otherwise, forcing is not generated due to a crash.
- modified: UFS_IC_generator.py
- modified: extract_FV3GFS_column_ic.py
1) Add wildcard character * for various output filenames, e.g., gfs.t00z.atmf0000.nc, gfs.t00z.sfcf0000.nc, oro_C96.mx100.tile1.nc. 2) Add soil color (a new soil property in Noah-MP) to get LSM IC set correctly, otherwise, forcing is not generated due to a crash modified: UFS_IC_generator.py modified: extract_FV3GFS_column_ic.py
bluefinweiwei
requested review from
dustinswales,
grantfirl and
mkavulich
as code owners
|
@bluefinweiwei These changes look fine to me, and the UFS-replay CI test passes, so good job! |
I don't think that this is being used anymore. I think that this was a precursor to UFS_IC_generator.py from Phil Pegion that I slightly modified. I think that we can probably safely remove it from the repo going forward. |
|
@bluefinweiwei I'm combining these changes into #459 with others to streamline the open PRs, so I'm closing this. Thanks for the work! |
|
Sounds great, thanks! |
Combination PR for #419, 428, 435, 445, 446, 458
