Add initial support for S3 active storage

[markgoddard]

In activestorage/config.py:

• Set USE_S3 = True
• Set S3_* to appropriate values for your setup

[valeriupredoi]

Hi @markgoddard - this is great, very many thanks! I've added a few review observations, please - I can plug in the changes, if you don't have time to do them. But one thing we need is a few test cases - am not very familiar with using the S3 interface for CI testing, so I might need your help there. If you could post one or two example tests then I can probably expand on those 👍 🍺

[markgoddard]

Thanks for the review.

[markgoddard]

Hi @markgoddard - this is great, very many thanks! I've added a few review observations, please - I can plug in the changes, if you don't have time to do them. But one thing we need is a few test cases - am not very familiar with using the S3 interface for CI testing, so I might need your help there. If you could post one or two example tests then I can probably expand on those +1 beer

We should be able to use the existing test cases, with USE_S3 = True and S3 active storage and minio running. It would be similar to the compliance tests in our CI: https://github.com/stackhpc/s3-active-storage-rs/blob/c62d757e5fef4861e91f4f8f064bf4abb8fc09b7/.github/workflows/pull-request.yml#L25

[valeriupredoi]

Hi @markgoddard - this is great, very many thanks! I've added a few review observations, please - I can plug in the changes, if you don't have time to do them. But one thing we need is a few test cases - am not very familiar with using the S3 interface for CI testing, so I might need your help there. If you could post one or two example tests then I can probably expand on those +1 beer

We should be able to use the existing test cases, with USE_S3 = True and S3 active storage and minio running. It would be similar to the compliance tests in our CI: https://github.com/stackhpc/s3-active-storage-rs/blob/c62d757e5fef4861e91f4f8f064bf4abb8fc09b7/.github/workflows/pull-request.yml#L25

great! Cheers, let me do that then - plug a few tests here, then I'll merge 👍

[valeriupredoi]

very many thanks @markgoddard - I'll plug in a couple tests based on your examples, then merge. Next step will be to update #47 to hold the S3 configuration in a yaml file rather than a Py module, and will ping you there for a review, if that's OK with you. Also, if that's OK with you, I'll add you as a contributor to this repo (make things easy for GitHub communications) 🍺

[markgoddard]

very many thanks @markgoddard - I'll plug in a couple tests based on your examples, then merge. Next step will be to update #47 to hold the S3 configuration in a yaml file rather than a Py module, and will ping you there for a review, if that's OK with you. Also, if that's OK with you, I'll add you as a contributor to this repo (make things easy for GitHub communications) beer

Perfect, thanks

[valeriupredoi]

just merged this, so I don't have to faff around with your fork - gonna open a PR now to plug in some tests. Now that you are a contributor here, you can just open vanilla PRs w/o having to go through forks, @markgoddard - and many thanks again for your contributions 🍺