Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly formatted ORCID are accepted #2553

Open
FiannaOBrien opened this issue Oct 16, 2024 · 1 comment · Fixed by #2576
Open

Incorrectly formatted ORCID are accepted #2553

FiannaOBrien opened this issue Oct 16, 2024 · 1 comment · Fixed by #2576
Assignees
Labels
Milestone

Comments

@FiannaOBrien
Copy link

Describe the bug
We've encountered an issue where users can submit incorrectly formatted ORCID. Specifically, the system currently accepts ORCIDs with more than 16 digits (e.g. “https://orcid.org/0000-0000-0001-9244-1708” rather than “https://orcid.org/0000-0001-9244-1708”)

To Reproduce
Steps to reproduce the behavior:

  1. Go to Metadata Landing page Editor
  2. Input contact ORCID with additional characters (e.g., "https://orcid.org/0000-0000-0001-9244-1708")
  3. Fill in other required fields
  4. Submit form

Expected behavior
The system should reject the ORCID with additional characters and display an error message indicating the correct format.

Additional context
Malformed ORCIDs are not accepted by OSTI and cause issues for the publication and reservation of DOIs

@robyngit robyngit self-assigned this Oct 21, 2024
@robyngit robyngit added this to the 2.32.0 milestone Oct 21, 2024
robyngit added a commit that referenced this issue Dec 4, 2024
- Add a new orcid validation method & associated tests

Fixes issue #2553
@robyngit robyngit linked a pull request Dec 4, 2024 that will close this issue
@robyngit
Copy link
Member

robyngit commented Dec 4, 2024

@FiannaOBrien I have a fix for this in PR #2576. If you are able to test it out, please let me know if this solves your issue! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants