-
Notifications
You must be signed in to change notification settings - Fork 7
/
stagedfright.py
370 lines (289 loc) · 11.9 KB
/
stagedfright.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
#################################################################################
# PRIMO - The P&A Project Optimizer was produced under the Methane Emissions
# Reduction Program (MERP) and National Energy Technology Laboratory's (NETL)
# National Emissions Reduction Initiative (NEMRI).
#
# NOTICE. This Software was developed under funding from the U.S. Government
# and the U.S. Government consequently retains certain rights. As such, the
# U.S. Government has been granted for itself and others acting on its behalf
# a paid-up, nonexclusive, irrevocable, worldwide license in the Software to
# reproduce, distribute copies to the public, prepare derivative works, and
# perform publicly and display publicly, and to permit others to do so.
#################################################################################
# stagedfright was originally developed as part of the PARETO project
# (https://github.com/project-pareto/project-pareto) and distributed under the following license:
#####################################################################################################
# PARETO was produced under the DOE Produced Water Application for Beneficial Reuse Environmental
# Impact and Treatment Optimization (PARETO), and is copyright (c) 2021-2024 by the software owners:
# The Regents of the University of California, through Lawrence Berkeley National Laboratory, et al.
# All rights reserved.
#
# NOTICE. This Software was developed under funding from the U.S. Department of Energy and the U.S.
# Government consequently retains certain rights. As such, the U.S. Government has been granted for
# itself and others acting on its behalf a paid-up, nonexclusive, irrevocable, worldwide license in
# the Software to reproduce, distribute copies to the public, prepare derivative works, and perform
# publicly and display publicly, and to permit others to do so.
#####################################################################################################
# Standard libs
import ast
import collections
import hashlib
import logging
import os
import subprocess
import sys
from dataclasses import dataclass
from pathlib import Path
from typing import Callable, Iterable, Iterator, List, Optional, Tuple, Union
# Installed libs
import pytest
from _pytest.terminal import TerminalReporter
# Original version and author information
NAME = "stagedfright"
__version__ = "2021.12.20"
__author__ = "Ludovico Bianchi"
_logger = logging.getLogger(NAME)
ALLOWFILE_SUFFIX = ".stagedfright-allowed"
class RepoOperationError(RuntimeError):
@classmethod
def from_subprocess_run(cls, completed_process):
return cls(
f"Repository operation with args {completed_process.args} did not succeed.\n"
f"returncode={completed_process.returncode}\n"
f"stderr={completed_process.stderr}"
)
def _get_git_output(args: Iterable[str], git_exe: os.PathLike = "git") -> str:
args = [git_exe] + list(args)
_logger.debug(f"subprocess args: {args}")
res = subprocess.run(
args,
text=True,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
)
if res.returncode != 0:
raise RepoOperationError.from_subprocess_run(res)
return res.stdout
def get_repo_root_dir() -> Path:
try:
path = _get_git_output(["rev-parse", "--show-toplevel"]).strip()
except RepoOperationError as e:
_logger.exception("Could not obtain repository root from git.")
raise e
return Path(path).resolve()
def get_git_staged_paths() -> List[Path]:
try:
lines = _get_git_output(["diff", "--staged", "--name-only"]).splitlines()
except RepoOperationError as e:
_logger.exception("Could not get staged files from git.")
raise e
return [Path(p) for p in lines]
_BasePathType = type(Path())
class StagedFile(_BasePathType):
@property
def fingerprint(self) -> str:
h = hashlib.sha256()
h.update(self.read_bytes())
return h.hexdigest()
@property
def text_content(self) -> Union[str, None]:
try:
return self.read_text()
except UnicodeDecodeError:
return None
@classmethod
def from_paths(cls, paths: Iterable[Path]) -> Iterator["StagedFile"]:
for path in paths:
if not path.is_file():
_logger.warning(
f'Trying to instantiate {cls} from "{path}", but it is not an existing file'
)
else:
yield cls(path)
@classmethod
def from_git_staged(cls) -> Iterator["StagedFile"]:
yield from cls.from_paths(get_git_staged_paths())
class AllowFile(_BasePathType):
@classmethod
def from_path(cls, path: Path) -> "AllowFile":
return cls(path.with_name(path.name + ALLOWFILE_SUFFIX))
@property
def fingerprint(self) -> str:
return self.read_text().strip()
@dataclass
class ASTNodes:
@classmethod
def from_source(cls, src: str, **kwargs):
return cls(root=ast.parse(src), **kwargs)
root: ast.AST
essential_types: Optional[Tuple[type]] = (ast.Assign, ast.Import, ast.ImportFrom)
literal_types: Optional[Tuple[type]] = ast.Constant
essential: Optional[List[ast.AST]] = None
literal: Optional[List[ast.AST]] = None
def __iter__(self):
yield from ast.walk(self.root)
def __post_init__(self):
self.essential = [n for n in self if isinstance(n, self.essential_types)]
self.literal = [n for n in self if isinstance(n, self.literal_types)]
@property
def literal_values(self) -> List:
return [n.value for n in self.literal]
@dataclass
class PyContent:
source: str
ast_nodes: Optional[ASTNodes] = None
objects: Optional[dict] = None
def __post_init__(self):
if self.ast_nodes is None:
self.ast_nodes = ASTNodes.from_source(self.source)
class StagedFright:
def __init__(self, items=None):
self.test_reports = collections.defaultdict(list)
self._items = list(items or [])
self.current = None
@pytest.hookimpl(tryfirst=True, hookwrapper=True)
def pytest_runtest_makereport(self, item, call) -> None:
outcome = yield
rep = outcome.get_result()
self.test_reports[self.current].append(rep)
def pytest_generate_tests(self, metafunc) -> None:
# if
if "staged" in metafunc.fixturenames:
metafunc.parametrize("staged", self._items, ids=str, indirect=True)
@pytest.fixture(scope="module")
# @pytest.fixture(scope="module", params=list(StagedFile.from_git_staged()), ids=os.fspath)
def staged(self, request) -> StagedFile:
staged = request.param
self.current = staged
yield staged
@pytest.fixture
def skip_if_matching_allowfile(self, staged: StagedFile) -> None:
allowfile = AllowFile.from_path(staged)
if not allowfile.exists():
return
if staged.fingerprint == allowfile.fingerprint:
pytest.skip(f'Matching allowfile found for "{staged}"')
@pytest.fixture
def allowfile(self, staged: StagedFile) -> AllowFile:
af = AllowFile.from_path(staged)
if not af.exists():
pytest.skip(f"No allowfile found for {staged}")
return af
@pytest.fixture
def staged_pycontent(self, staged: StagedFile) -> PyContent:
if staged.text_content is None:
pytest.xfail(f"{staged} is not a text file")
return PyContent(staged.text_content)
@property
def with_failing_tests(self) -> List:
return [
entry
for entry, reports in self.test_reports.items()
if not all([rep.outcome in {"passed", "skipped"} for rep in reports])
]
def pytest_terminal_summary(self, terminalreporter: TerminalReporter) -> None:
tr = terminalreporter
tr.section(NAME)
to_report = self.with_failing_tests
if not to_report:
tr.write_line("No failed checks among the inspected staged files.")
return
tr.write_line(
f"The following {len(to_report)} inspected staged file(s) failed one or more checks:"
)
for staged in to_report:
tr.write_line(f"\t{staged}")
tr.write_line(
"For each of these files, REVIEW IT CAREFULLY:"
"\n- If it *SHOULD NOT* be cleared for commit, unstage it immediately."
"\n- If instead it should, create an allowfile in the same directory, "
f'with the same name (including file extension) plus the "{ALLOWFILE_SUFFIX}" suffix, '
"containing the fingerprint (SHA256 hash) of the file."
)
tr.ensure_newline()
tr.write_line("\te.g.:")
for staged in self.with_failing_tests:
allowfile = AllowFile.from_path(staged)
tr.write_line(
f'\tFor staged file "{staged}", create "{allowfile}" with content: {staged.fingerprint}'
)
def pytest_run(
to_inspect: Iterable[Path],
testpath: os.PathLike,
verbose: bool = True,
ignore_ini_file: bool = True,
collect_all: bool = True,
) -> pytest.ExitCode:
items = list(StagedFile.from_paths(to_inspect))
testpath = Path(testpath).resolve()
_logger.info(
f"Inspecting {len(items)} staged items using checks collected from {testpath}"
)
sf = StagedFright(items)
pytest_args = [
os.fspath(testpath),
"-s",
]
if collect_all:
pytest_args += ["-o", "python_files=*.py"]
if ignore_ini_file:
null_target = "NUL" if sys.platform.startswith("win") else "/dev/null"
pytest_args += ["-c", null_target]
pytest_args += ["-v"] if verbose else ["-qq"]
_logger.debug(f"Calling pytest.main with args: {pytest_args}")
return pytest.main(
pytest_args,
plugins=[sf],
)
class ExitCode:
no_unguarded_detected: int = 0
unguarded_detected: int = 1
internal_error: int = 2
no_inspection_performed: int = 5
def notify_exit(code: int, log: Callable[[str], None] = _logger.info):
log(f"{NAME} will now exit with code: {code}")
return code
def main(args: Optional[List[str]] = None) -> int:
logging.basicConfig(level=logging.DEBUG)
_logger.info(f"{NAME}, version: {__version__}")
args = args or sys.argv[1:]
_logger.debug(f"args={args}")
try:
root_dir = get_repo_root_dir()
except RepoOperationError:
_logger.critical("Could not determine the root of the repository. ")
return notify_exit(ExitCode.internal_error)
else:
_logger.info(f"Starting inspection for repository directory: {root_dir}")
try:
staged_paths = get_git_staged_paths()
except RepoOperationError:
_logger.critical("Could not determine staged files for this repository.")
return notify_exit(ExitCode.internal_error)
else:
_logger.info(f"{len(staged_paths)} items are currently staged")
if _logger.isEnabledFor(logging.DEBUG):
for path in staged_paths:
_logger.debug(f"\t{path}")
if not staged_paths:
_logger.warning("No staged files detected.")
return notify_exit(ExitCode.no_inspection_performed)
# TODO add properly parsed arguments
testfile = args[0]
try:
pytest_run_res = pytest_run(staged_paths, testfile, verbose=True)
except Exception:
_logger.exception("Unexpected error occurred during inspection.")
_logger.critical(
"Inspection could not be completed because of an internal error."
)
return notify_exit(ExitCode.internal_error)
_logger.debug(f"pytest run result: {pytest_run_res}")
_logger.info("Inspection completed successfully.")
if pytest_run_res == 0:
_logger.info("No unguarded files have been detected.")
return notify_exit(ExitCode.no_unguarded_detected)
_logger.error("Unguarded files have been detected.")
return notify_exit(ExitCode.unguarded_detected)
if __name__ == "__main__":
sys.exit(main())