Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributors page render error #212

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Contributors page render error #212

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca497b3
Wrap FutureBuilder with Expanded widget
James-Lu-none Oct 26, 2023
f67b272
Modify Expanded widget warpping scope
James-Lu-none Oct 26, 2023
db85b52
dart format
James-Lu-none Oct 26, 2023
d048dd5
dart format
James-Lu-none Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 33 additions & 31 deletions lib/ui/pages/other/page/contributors_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,42 +93,44 @@ class ContributorsPage extends StatelessWidget {
builder: (context, snapshot) {
if (snapshot.hasData) {
final contributorList = snapshot.data;
return ListView.builder(
itemCount: contributorList?.length,
shrinkWrap: true,
itemBuilder: (context, index) {
final contributor = contributorList![index];
return Expanded(
child: ListView.builder(
itemCount: contributorList?.length,
shrinkWrap: true,
itemBuilder: (context, index) {
final contributor = contributorList![index];

return InkWell(
onTap: () {
RouteUtils.toWebViewPage(initialUrl: Uri.parse(contributor.htmlUrl ?? ''));
},
child: WidgetAnimator(
Container(
padding: const EdgeInsets.only(top: 5, bottom: 5, left: 10),
child: Row(
children: [
SizedBox(
height: 50,
width: 50,
child: CachedNetworkImage(
imageUrl: contributor.avatarUrl ?? '',
imageBuilder: (context, imageProvider) => CircleAvatar(
radius: 15.0,
backgroundImage: imageProvider,
return InkWell(
onTap: () {
RouteUtils.toWebViewPage(initialUrl: Uri.parse(contributor.htmlUrl ?? ''));
},
child: WidgetAnimator(
Container(
padding: const EdgeInsets.only(top: 5, bottom: 5, left: 10),
child: Row(
children: [
SizedBox(
height: 50,
width: 50,
child: CachedNetworkImage(
imageUrl: contributor.avatarUrl ?? '',
imageBuilder: (context, imageProvider) => CircleAvatar(
radius: 15.0,
backgroundImage: imageProvider,
),
),
),
),
const Padding(
padding: EdgeInsets.only(left: 10),
),
Text(contributor.login ?? '')
],
const Padding(
padding: EdgeInsets.only(left: 10),
),
Text(contributor.login ?? '')
],
),
),
),
),
);
},
);
},
),
);
} else if (snapshot.hasError) {
return const Center(
Expand Down
Loading