Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

遷移 Course Connector 至 v3 與重構 Course Connector 實作細節 #221

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
c0999b7
Refactor: Migrate course related JSON
ntut-xuan Feb 2, 2024
540eca7
Fix: Loading semester list when year and semester not exists.
ntut-xuan Feb 2, 2024
488dc96
Refactor: course_connector.dart
ntut-xuan Feb 4, 2024
8fda432
Refactor: course_connector.dart
ntut-xuan Feb 8, 2024
22a870b
Migrate: Remove redundant json
ntut-xuan Feb 8, 2024
0d2b1c0
Rename: course_syllabus and course_semester
ntut-xuan Feb 8, 2024
f10d450
Migrate: Remove must.dart
ntut-xuan Feb 9, 2024
27770d7
Chore: format
ntut-xuan Feb 9, 2024
a1471a1
Chore: fix the issues from analyzer
ntut-xuan Feb 9, 2024
c0d8d0a
Chore: format
ntut-xuan Feb 9, 2024
4aa1390
Implement: Use EEquatableMixin to instead of operator overloading
ntut-xuan Feb 12, 2024
65d8bc8
Implement: use final when the value won't modify
ntut-xuan Feb 12, 2024
4ae3cde
Implement: use final when the value won't modify
ntut-xuan Feb 12, 2024
7ca37d3
Implement: use final when the value won't modify
ntut-xuan Feb 12, 2024
24d296a
Implement: use final when the value won't modify
ntut-xuan Feb 12, 2024
530cea0
Chore: Change required key to nullable key
ntut-xuan Feb 12, 2024
1eea804
Chore: Simply the unique process with Set data structure
ntut-xuan Feb 12, 2024
29e7c9b
Chore: Simply the unique process with addAll function
ntut-xuan Feb 12, 2024
df623de
Chore: Simply getUnknownCourse when reuse complex method chains
ntut-xuan Feb 12, 2024
b4b19a3
Chore: Add comma after the final things in a series of long parameters
ntut-xuan Feb 12, 2024
4dc5e46
Chore: Optimize huge function chain when Pre-build member
ntut-xuan Feb 12, 2024
54e8d44
Chore: Run format
ntut-xuan Feb 12, 2024
dfcf849
Chore: Optimize the implementation by add a value-mapping constructor
ntut-xuan Feb 12, 2024
8ee64bb
Chore: Run format
ntut-xuan Feb 12, 2024
f990968
Chore: Add origin constructor & passed analyze & format it
ntut-xuan Feb 12, 2024
fb295cd
Chore: Add final
ntut-xuan Feb 12, 2024
03b73c2
Chore: Add final & adding trailing commas
ntut-xuan Feb 12, 2024
5ece6bf
Chore: Format
ntut-xuan Feb 12, 2024
1b5da58
Chore: Adding trailing commas
ntut-xuan Feb 12, 2024
e3f75f4
Chore: Add final in data transfer object
ntut-xuan Feb 12, 2024
33f07fe
Chore: Add final
ntut-xuan Feb 12, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ SPEC CHECKSUMS:
FirebaseCoreExtension: 2dbc745b337eb99d2026a7a309ae037bd873f45e
FirebaseCoreInternal: 26233f705cc4531236818a07ac84d20c333e505a
FirebaseCrashlytics: a83f26fb922a3fe181eb738fb4dcf0c92bba6455
FirebaseFirestore: 58d92e3cc19fd1c93e279d466aaf148ce6dbf635
FirebaseFirestore: 9a14eef134fd586d8200f4dfa0ee3cb093a05d8f
FirebaseInstallations: b822f91a61f7d1ba763e5ccc9d4f2e6f2ed3b3ee
FirebaseMessaging: 0c0ae1eb722ef0c07f7801e5ded8dccd1357d6d4
FirebaseRemoteConfig: 64b6ada098c649304114a817effd7e5f87229b11
Expand Down
14 changes: 7 additions & 7 deletions lib/generated/intl/messages_all.dart
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ import 'package:intl/src/intl_helpers.dart';
import 'messages_en.dart' as messages_en;
import 'messages_zh_TW.dart' as messages_zh_tw;

typedef Future<dynamic> LibraryLoader();
typedef LibraryLoader = Future<dynamic> Function();
Map<String, LibraryLoader> _deferredLibraries = {
'en': () => new SynchronousFuture(null),
'zh_TW': () => new SynchronousFuture(null),
'en': () => SynchronousFuture(null),
'zh_TW': () => SynchronousFuture(null),
};

MessageLookupByLibrary? _findExact(String localeName) {
Expand All @@ -41,13 +41,13 @@ Future<bool> initializeMessages(String localeName) {
var availableLocale =
Intl.verifiedLocale(localeName, (locale) => _deferredLibraries[locale] != null, onFailure: (_) => null);
if (availableLocale == null) {
return new SynchronousFuture(false);
return SynchronousFuture(false);
}
var lib = _deferredLibraries[availableLocale];
lib == null ? new SynchronousFuture(false) : lib();
initializeInternalMessageLookup(() => new CompositeMessageLookup());
lib == null ? SynchronousFuture(false) : lib();
initializeInternalMessageLookup(() => CompositeMessageLookup());
messageLookup.addLocale(availableLocale, _findGeneratedMessagesFor);
return new SynchronousFuture(true);
return SynchronousFuture(true);
}

bool _messagesExistFor(String locale) {
Expand Down
4 changes: 2 additions & 2 deletions lib/generated/intl/messages_en.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
import 'package:intl/intl.dart';
import 'package:intl/message_lookup_by_library.dart';

final messages = new MessageLookup();
final messages = MessageLookup();

typedef String MessageIfAbsent(String messageStr, List<dynamic> args);
typedef MessageIfAbsent = String Function(String messageStr, List<dynamic> args);

class MessageLookup extends MessageLookupByLibrary {
String get localeName => 'en';
Expand Down
4 changes: 2 additions & 2 deletions lib/generated/intl/messages_zh_TW.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
import 'package:intl/intl.dart';
import 'package:intl/message_lookup_by_library.dart';

final messages = new MessageLookup();
final messages = MessageLookup();

typedef String MessageIfAbsent(String messageStr, List<dynamic> args);
typedef MessageIfAbsent = String Function(String messageStr, List<dynamic> args);

class MessageLookup extends MessageLookupByLibrary {
String get localeName => 'zh_TW';
Expand Down
Loading
Loading