Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read-only runcards objects #205

Open
1 of 2 tasks
alecandido opened this issue Jan 27, 2023 · 1 comment
Open
1 of 2 tasks

Read-only runcards objects #205

alecandido opened this issue Jan 27, 2023 · 1 comment
Labels
output Output format and management refactor Refactor code
Milestone

Comments

@alecandido
Copy link
Member

alecandido commented Jan 27, 2023

Runcards objects should mirror exactly the user input.

E.g. Rotations in OperatorCards contains a lot of members that should never be set by the user, and are only modified later on. This should definitely fit somewhere else.

Let's review this objects as soon as possible. They should also not be loaded from dictionaries containing leading _ keys.

@andreab1997 provide your feedback about the new runcards.

@alecandido alecandido modified the milestones: 1.0.0-a.1, 1.0.0-b.1 Jan 27, 2023
@felixhekhorn felixhekhorn added refactor Refactor code output Output format and management labels Jan 30, 2023
@felixhekhorn
Copy link
Contributor

Note that #183 is related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
output Output format and management refactor Refactor code
Projects
None yet
Development

No branches or pull requests

2 participants