Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more examples to run on CI #313

Closed
Radonirinaunimi opened this issue Sep 25, 2024 · 4 comments
Closed

Add more examples to run on CI #313

Radonirinaunimi opened this issue Sep 25, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@Radonirinaunimi
Copy link
Member

Radonirinaunimi commented Sep 25, 2024

Triggered by this comment I think it'd be indeed good to run the Python examples on the CI. Indeed, while running all of the examples, the Python ones broke which I fixed in #310. More Python examples should also be added.

@Radonirinaunimi Radonirinaunimi added the enhancement New feature or request label Sep 25, 2024
@Radonirinaunimi Radonirinaunimi self-assigned this Sep 25, 2024
@cschwan
Copy link
Contributor

cschwan commented Sep 25, 2024

The C, C++ and Fortran APIs are run, tested and code coverage is generated here: https://github.com/NNPDF/pineappl/blob/master/.github/workflows/capi.yaml. For the Python interface we should have more examples, run and test them in the CI, of course.

@Radonirinaunimi Radonirinaunimi changed the title Run examples on CI Add more examples to run on CI Sep 25, 2024
@Radonirinaunimi
Copy link
Member Author

Radonirinaunimi commented Sep 25, 2024

The C, C++ and Fortran APIs are run, tested and code coverage is generated here: https://github.com/NNPDF/pineappl/blob/master/.github/workflows/capi.yaml. For the Python interface we should have more examples, run and test them in the CI, of course.

Ah, yes! Then it is just about adding more Python examples and also run them on the CI.

EDIT: Updated the description.

@cschwan
Copy link
Contributor

cschwan commented Sep 25, 2024

Then I believe this is a duplicate of #108.

@Radonirinaunimi
Copy link
Member Author

I agree, I will implement this there.

@Radonirinaunimi Radonirinaunimi linked a pull request Sep 25, 2024 that will close this issue
@cschwan cschwan removed a link to a pull request Oct 24, 2024
@cschwan cschwan closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants