Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated renormalization SV does not work at N3LO (and beyond) #144

Closed
felixhekhorn opened this issue Dec 14, 2023 · 14 comments · Fixed by #145
Closed

Generated renormalization SV does not work at N3LO (and beyond) #144

felixhekhorn opened this issue Dec 14, 2023 · 14 comments · Fixed by #145
Assignees
Labels
bug Something isn't working

Comments

@felixhekhorn
Copy link
Contributor

ren_sv_coeffs does not work at N3LO, as it seems hardcoded to NNLO:

if max_as == 0:
return 0.0
if max_as == 2:
if which_part > 0:
m += 1
elif logpart > 1:
m = 0.5 * m * (m + 1)
return m * as_normalization * bcoeff

If you don't want to do the fully general math (which I guess should be Bell polynomials - look at the second formula image under properties), you could still do an explicit spell out (as N4LO is far future, hopefully) ...

The relevant coeffs can be found in the MHOU paper:
grafik

cc @giacomomagni

@felixhekhorn felixhekhorn added the bug Something isn't working label Dec 14, 2023
@andreab1997
Copy link
Contributor

Yes for the moment N3LO ren sv is not supported but surely we can add (and I will as soon as I have time to do it). Is this needed now?

@giacomomagni
Copy link
Contributor

giacomomagni commented Dec 14, 2023

Oh damn, thanks for checking @felixhekhorn,
I completely overlooked at this as I never check it.

Yes for the moment N3LO ren sv is not supported but surely we can add (and I will as soon as I have time to do it). Is this needed now?

Yes they are needed for DIS where we do have N3LO effects.

@giacomomagni
Copy link
Contributor

giacomomagni commented Dec 14, 2023

But wait, for DIS we have them from Yadism, so are the codes doing the correct thing here?

@andreab1997
Copy link
Contributor

Oh damn, thanks for checking @felixhekhorn, I completely overlooked at this as I never check it.

Yes for the moment N3LO ren sv is not supported but surely we can add (and I will as soon as I have time to do it). Is this needed now?

Yes they are needed for DIS where we do have N3LO effects.

This I know but I believed that for DIS yadism would provide the scale variations

@felixhekhorn
Copy link
Contributor Author

This I know but I believed that for DIS yadism would provide the scale variations

yes, yadism can indeed provide all SV (both ren and fact) at all orders (you have to request it though)

I was more worried about n3loxs or Higgs (or in general the N3LO pheno)

@felixhekhorn felixhekhorn changed the title Generated reormalization SV does not work at N3LO (and beyond) Generated renormalization SV does not work at N3LO (and beyond) Dec 14, 2023
@andreab1997
Copy link
Contributor

This I know but I believed that for DIS yadism would provide the scale variations

yes, yadism can indeed provide all SV (both ren and fact) at all orders (you have to request it though)

I was more worried about n3loxs or Higgs (or in general the N3LO pheno)

For the moment we do not have even the N3LO central for most of the datasets, so we are not using anywhere the N3LO sv (apart from DIS and for few DY points, as far as I know)

@giacomomagni
Copy link
Contributor

giacomomagni commented Dec 14, 2023

yes, yadism can indeed provide all SV (both ren and fact) at all orders (you have to request it though)

wait at N3LO only ren scale are available in yadism: NNPDF/yadism#150

I was more worried about n3loxs or Higgs (or in general the N3LO pheno)

So far I was using the scale varied KF or computing sv directly using the given n3lo code, but I believe this feature can be quite useful in pineko in future.
And it doesn't require much work.

@felixhekhorn
Copy link
Contributor Author

yes, yadism can indeed provide all SV (both ren and fact) at all orders (you have to request it though)

wait at N3LO on ren scale are available in yadism: NNPDF/yadism#150

you're right and I'm wrong - there is neither fact. nor ren. SV at N3LO in yadism 😱 the ren should be here, but it isn't:
https://github.com/NNPDF/yadism/blob/3a2552c8e3c53f7d80c1d5d5b159c00df9240b8f/src/yadism/esf/scale_variations.py#L129

I was more worried about n3loxs or Higgs (or in general the N3LO pheno)

So far I was using the scale varied KF or computing sv directly using the given n3lo code, but I believe this feature can be quite useful in pineko in future. And it doesn't require much work.

does this mean we the N3LO fits are safe for the moment? (or do we need to panic?)

@andreab1997
Copy link
Contributor

Yes sure I will do this, I was just asking to know if I need to do this now or if it can wait. I would say it can wait

@andreab1997
Copy link
Contributor

yes, yadism can indeed provide all SV (both ren and fact) at all orders (you have to request it though)

wait at N3LO on ren scale are available in yadism: NNPDF/yadism#150

you're right and I'm wrong - there is neither fact. nor ren. SV at N3LO in yadism 😱 the ren should be here, but it isn't: https://github.com/NNPDF/yadism/blob/3a2552c8e3c53f7d80c1d5d5b159c00df9240b8f/src/yadism/esf/scale_variations.py#L129

I was more worried about n3loxs or Higgs (or in general the N3LO pheno)

So far I was using the scale varied KF or computing sv directly using the given n3lo code, but I believe this feature can be quite useful in pineko in future. And it doesn't require much work.

does this mean we the N3LO fits are safe for the moment? (or do we need to panic?)

What? N3LO sv are not in yadism then?

@giacomomagni
Copy link
Contributor

giacomomagni commented Dec 14, 2023

But what about this then ? We added only NNLO? Aren't we messing up with names?

https://github.com/NNPDF/yadism/pull/174/files

@felixhekhorn
Copy link
Contributor Author

But what about this then ? We added only NNLO? Aren't we messing up with names?

https://github.com/NNPDF/yadism/pull/174/files

you're right - I'm sorry, I successfully confused myself ... I was remembering correctly in the first place - for yadism $m=0$ (in the MHOU paper language) and so everything shifts one order up ... good, yadism is safe!

however, here in pineko we could not rely on $m=0$ of course

@alecandido
Copy link
Member

If you don't want to do the fully general math (which I guess should be Bell polynomials - look at the second formula image under properties), you could still do an explicit spell out (as N4LO is far future, hopefully) ...

In case, this is a dependency we can afford in Pineko

https://docs.sympy.org/latest/modules/functions/combinatorial.html

It's stable, and in Pineko performances are not critical (the tools to which is delegating the workload are responsible for performances).

@giacomomagni
Copy link
Contributor

giacomomagni commented Dec 14, 2023

does this mean we the N3LO fits are safe for the moment? (or do we need to panic?)

So my understanding is that N3LO fits should be safe as the variant with DY KF should come with SV in the kfactor and vp-setupfit is able to deal with them.

Regarding the baseline fits, ren scale variations at N3LO will come from yadism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants