Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Timelike with up to 2 ekos #192

Closed
wants to merge 2 commits into from
Closed

Conversation

giacomomagni
Copy link
Contributor

Support time-like evolution with up to 2 ekos.

@giacomomagni giacomomagni added the physics Physics feature label Aug 23, 2024
@giacomomagni
Copy link
Contributor Author

@t7phy I'll leave to you the pleasure to test and check if it works...
Most likely there is some corner case left 😅

@giacomomagni giacomomagni requested a review from t7phy August 23, 2024 13:02
@giacomomagni giacomomagni linked an issue Aug 23, 2024 that may be closed by this pull request
@@ -245,10 +245,6 @@ def write_operator_card(pineappl_grid, default_card, card_path, tcard):
kv = pineappl_grid.key_values()
conv_type_1, conv_type_2 = get_grid_convolution_type(kv)

# fragmentation function grid?
if "timelike" in kv:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the previous implementation was not even working cause the "True" business

@scarlehoff
Copy link
Member

Deprecated by #206

@scarlehoff scarlehoff closed this Nov 27, 2024
@scarlehoff scarlehoff deleted the support_timelike branch November 27, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physics Physics feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generalize evolve to accommodate two EKOs
2 participants