-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fktables for NLO theory #62
Comments
@cschwan @enocera Could you please have a look to the grids with the missing ren scale variations of the list above (third list)? How should we proceed? For example we are missing lots of total cross sections for TTBAR which are not in the pinecard repo. However the repo provides differential cross-sections. Should we add the missing? |
The top-pair production grids should be available in https://github.com/NNPDF/pineapplgrids, one of them possibly in a branch. All other would have to be implemented in https://github.com/NNPDF/runcards. |
Thank you very much. So the grids in https://github.com/NNPDF/pineapplgrids contain ren scale variations? |
@cschwan for the elements in the fifth list above ("things to check") we don't have any clear clue on what the problem is ... some of the bins (but not all) are matching and others are completely off. Do you see any common pattern for the datasets? @andreab1997 checked that the ekos are fine and also the grids are fine (as we knew from before). So now we're suspecting maybe pineko or pineappl (i.e. As for pineko: there is actually almost nothing, but the |
They should! You can explicitly check this if you run the CLI using |
This could well be, yet another reason to have a unit test for this ... I can test this, but I'm afraid I won't be able to this week. If you want to test this yourself, try
which will checkout PineAPPL before the changes. I hope that the Python API still works. |
I have done some tests and I can add some details. As expected, I was able to produce the correct Fktables with older versions of pineko, eko and pineappl. In particular I used |
You should be able to do the same with every version of |
Yes I can try but |
Apart from what the package require, you should be able to use a newer version (if not through Poetry, manually). Might be that something is broken, but something is not everything. Or do you know that there is something required in |
I don't know, most likely nothing is broken. Indeed I launched the job and it did not crash until now. It was just a possibility :) |
I can confirm that even with |
So do we conclude that |
For the tested data set, yes. Unless we are deeply misunderstanding something. |
OK; is there an immediate action needed or is rolling back to a previous version sufficient? |
It is sufficient to get the correct results. However, since we need to downgrade even pineko, we have other modifications that we probably don't want. Moreover, it is a lot slower (factor 6 more or less) which is a problem given the number of fktables to compute. So I believe that we need to solve the bug. |
We definitely need to fix this. However, I'm a bit busy for the remainder of this week and therefore I was trying to gauge the urgency; from your answer I suppose it is urgent, so we have to come up with a plan. Do you have an idea in which cases the generation fails (all processes or just some)? Ideally we'd implement a minimal test case here: NNPDF/pineappl#122. Does the generation of the positivity FK tables fail? |
I don't think that the positivity fails, but I did not test recently. If you want I can. The list of the datasets that are failing is the fourth ("Thing to check"), while for example all the drell yan are not (and of course there are others that are correct). |
Just to point out that @felixhekhorn start doubting the problem being PineAPPL in another thread NNPDF/pineappl#103 (comment) |
I have tried to use the version of pineappl given by this checkout together again with pineko=0.1.1 and it worked for the dataset I am testing (which is ATLASWZRAP36PB). Of course it would be nice to instead use pineko=0.1.2 but this is not doable unfortunately because it is uncompatible with that version of pineappl. So at the end we can only conclude that the error, if it is in pineappl, is after this commit and, if it is in pineko, is between 0.1.1 and 0.1.2. |
Of course I am assuming that if it is working for ATLASWZRAP36PB (that was wrong with the most recent versions) it would work for all the others that were wrong. I believe it is a very reasonable assumption but we should keep this in mind while debugging. Of course you have any other suggestion for datasets to test, please tell me. We have chosen ATLASWZRAP36PB only because is reasonably little and fast. |
Do you have the EKO for ATLASWZRAP36PB as a file somewhere where I have access to (dom, montblanc)? |
Yes it is on dom. Precisely in |
Great, thanks a lot - that's exactly what I need. I'll try to build a unit test for |
Perfect, thank you very much. |
Looking at the grids that are in https://github.com/NNPDF/pineapplgrids, none of them are what we really need (as specified in the list "We miss ren sv" above. I was wondering if maybe they have just different names but then, is there a "dictionary" somewhere? |
The dictionary at the moment is inside Essentially, the two nomenclatures are:
Unfortunately, if they were not in theory 200/400, you have to find the mapping on your own. However, it is not unlikely that quite a few grids have still to be generated. |
Yes but in fact the names that I have put in that list are exactly coming from the |
For example, for |
All the
However, it's possible that the scales are chosen differently in those grids, so if you compare against the APPLgrid-converted grids keep that in mind. |
Ok, thank you! So, for example, for ATLASTTBARTOT7TEV I should use ATLAS_TTB_7TEV_TOT.pineappl.lz4 even if in the yaml file I have ATLASTTBARTOT7TEV-TOPDIFF7TEVTOT.pineappl.lz4, right? (i.e. just the names are changed) |
As far as I know they're all the same grid, although they have different names. You should check that, for instance with the CLI: |
Actually I tried but it results in an error. pineappl diff ../data/grids/4/ATLASTTBARTOT8TEV-TOPDIFF8TEVTOT.pineappl.lz4 pineapplgrids/ATLAS_TTB_8TEV_TOT.pineappl.lz4 NNPDF40_nlo_as_01180 Caused by: Am I doing something wrong? |
Did you check out the |
Yes this was the problem, thank you! However if now I try So is this enough to conclude that I can use |
If you do |
However I am confused by the |
This should be a fully inclusive cross section so any binning (x1) is just fake - however, pineappl requires some sort of binning for technical reason and so you can create whatever bin ... it should not matter |
If you can, provide a yamldb entry spelling the actual translation. The yamldb has been initially generated from But you see it was a manual action, based on @cschwan explaining part of the matching, and @felixhekhorn finding the rest of them. If you are lucky, you can find them all there (but then most likely also in the yamldb), otherwise you have to find the matching yourself. So, yes, if they match (common orders) they are the same. |
Maybe we should prompt to speed up new Commondata implementation, since they will be the proper and final solution. |
this is a nice to have and the proper solution, but we are not correlated to them at the moment - we're maintaining our own DB |
But our own DB has no proper source. Until now we use the instance inside theory 400, and now is not enough any longer. |
The renormalization-scale grids:
Jet grids on ploughshare: We can convert those now, however the conversion of the log grids isn't implemented yet, see NNPDF/pineappl#171. |
This is the NLO eqiuivalent of NNPDF/fktables#5
We list here the Fktables which we cannot compute at the moment for the central NLO theory (208):
The text was updated successfully, but these errors were encountered: