Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a new tag or release for reportengine #59

Open
scarlehoff opened this issue Oct 30, 2023 · 4 comments
Open

Create a new tag or release for reportengine #59

scarlehoff opened this issue Oct 30, 2023 · 4 comments

Comments

@scarlehoff
Copy link
Member

reportengine has changed quite a lot since the last tag/release, in particular the dash stuff that @comane added clearly warrants a new release/tag NNPDF/nnpdf#1804 (comment)

And an associated question which should have been formulated sooner... @Zaharid are you planning to keep on maintaining reportengine?
@Zaharid
Copy link
Contributor

Zaharid commented Oct 30, 2023

I would not count on that.

That said I can try to make sure the code is distributed in various places when the teats pass.

@scarlehoff
Copy link
Member Author

@comane is the PR #57 fixing the test that is failing master?

@comane
Copy link
Member

comane commented Oct 30, 2023

@scarlehoff I just closed PR #57 since it was not needed anymore after merging #56

To what test are you referring to?

@scarlehoff
Copy link
Member Author

https://github.com/NNPDF/reportengine/actions/runs/5762321933/job/15621863471

@scarlehoff scarlehoff mentioned this issue Nov 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Zaharid @scarlehoff @comane