Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logic issue in ush/wave_grid_interp_sbs.sh #3162

Open
JessicaMeixner-NOAA opened this issue Dec 12, 2024 · 0 comments
Open

logic issue in ush/wave_grid_interp_sbs.sh #3162

JessicaMeixner-NOAA opened this issue Dec 12, 2024 · 0 comments
Assignees
Labels
bug Something isn't working triage Issues that are triage

Comments

@JessicaMeixner-NOAA
Copy link
Contributor

What is wrong?

@aerorahul discovered a bug in ush/wave_grid_interp_sbs.sh which we have:
if [ "wht_OK" = 'no' ]

which will never evaluate to true, but then if this is true, we try to copy to fix, which is not okay.....

What should have happened?

We should figure out this code logic and re-code or remove, etc.

What machines are impacted?

All or N/A

What global-workflow hash are you using?

#3098

Steps to reproduce

Make if [ "wht_OK" = 'no' ] -> if [ "${wht_OK}" = 'no' ]

Additional information

No response

Do you have a proposed solution?

No response

@JessicaMeixner-NOAA JessicaMeixner-NOAA added bug Something isn't working triage Issues that are triage labels Dec 12, 2024
@JessicaMeixner-NOAA JessicaMeixner-NOAA self-assigned this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Issues that are triage
Projects
None yet
Development

No branches or pull requests

1 participant