Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove STRICT=NO from OCEAN jjobs #1861

Merged

Conversation

AndrewEichmann-NOAA
Copy link
Contributor

Description

This removes the STRICT=NO from OCEAN jjobs, allowing for strict checking of unassigned environment variables within the marine scripts. Previously these were set apparently as a workaround for environment variables that were not set in GDASApp SOCA ctests.

Resolves #1837
Previously merged dependency: NOAA-EMC/GDASApp#624

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

Tested with GDASApp SOCA ctests on Hera

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

@AndrewEichmann-NOAA AndrewEichmann-NOAA marked this pull request as ready for review September 14, 2023 13:49
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewEichmann-NOAA
Copy link
Contributor Author

FYI @guillaumevernieres and @CoryMartin-NOAA

@aerorahul aerorahul merged commit 2b73f0e into NOAA-EMC:develop Sep 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unassigned env variables in ocean jjob scripts
2 participants