Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow APP to differ between RUNs #2943

Merged
merged 58 commits into from
Nov 26, 2024
Merged

Allow APP to differ between RUNs #2943

merged 58 commits into from
Nov 26, 2024

Conversation

DavidHuber-NOAA
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA commented Sep 19, 2024 •
edited
Loading

Description

This enables APP to be specified for each RUN. This also removes the need for a _no_run configuration dictionary and somewhat simplifies the _init_finalize method.

Resolves #2908
Resolves #2956

Type of change

  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any submodules? NO

How has this been tested?

  • Generated .xml files on Hera for all available CI tests and verified they were identical to develop.
  • Created an arbitrary APP configuration ({"gdas": "S2S", "gfs": "ATM"})

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes

@DavidHuber-NOAA

This comment was marked as resolved.

Sign in to view
@DavidHuber-NOAA DavidHuber-NOAA marked this pull request as ready for review October 1, 2024 19:24
@DavidHuber-NOAA
Copy link
Contributor Author

This PR now correctly generates identical CI XMLs as compared to develop (with the exception of the stage_ic and cleanup jobs which are now run on service partitions). An additional case was tested based on the C96C48_hybatmaerosnowDA case, but the APP was set to ATMA for RUN==gdas and ATM for RUN==gfs. In this case, the gfs tasks in the resultant XML did not include any aero-component jobs.

Marking ready for review.

DavidHuber-NOAA
DavidHuber-NOAA commented Oct 2, 2024
View reviewed changes
workflow/applications/applications.py Outdated Show resolved Hide resolved
workflow/applications/gfs_cycled.py Outdated Show resolved Hide resolved
workflow/applications/applications.py Outdated Show resolved Hide resolved
workflow/applications/gfs_cycled.py Outdated Show resolved Hide resolved
workflow/applications/gfs_cycled.py Outdated Show resolved Hide resolved
workflow/applications/gfs_forecast_only.py Outdated Show resolved Hide resolved
workflow/rocoto/gfs_tasks.py Outdated Show resolved Hide resolved
workflow/rocoto/gfs_tasks.py Outdated Show resolved Hide resolved
@emcbot emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Nov 25, 2024
@emcbot
Copy link

emcbot commented Nov 25, 2024

Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 8 in
/scratch1/NCEPDEV/global/CI_dh/2943/RUNTESTS/EXPDIR/C96C48_hybatmaerosnowDA_74c08046

@DavidHuber-NOAA
Copy link
Contributor Author

The aerosol forecast failed to be included due to a typo in config.base. Killing the tests and relaunching on Hera.

@emcbot
Copy link

emcbot commented Nov 25, 2024

Experiment C48mx500_3DVarAOWCDA FAILED on Hera in Build# 8 in
/scratch1/NCEPDEV/global/CI_dh/2943/RUNTESTS/EXPDIR/C48mx500_3DVarAOWCDA_74c08046

@emcbot
Copy link

emcbot commented Nov 25, 2024

Experiment C48_S2SW FAILED on Hera in Build# 8 in
/scratch1/NCEPDEV/global/CI_dh/2943/RUNTESTS/EXPDIR/C48_S2SW_74c08046

@emcbot
Copy link

emcbot commented Nov 25, 2024

Experiment C96_atm3DVar FAILED on Hera in Build# 8 in
/scratch1/NCEPDEV/global/CI_dh/2943/RUNTESTS/EXPDIR/C96_atm3DVar_74c08046

@emcbot
Copy link

emcbot commented Nov 25, 2024

Experiment C96C48_ufs_hybatmDA FAILED on Hera in Build# 8 in
/scratch1/NCEPDEV/global/CI_dh/2943/RUNTESTS/EXPDIR/C96C48_ufs_hybatmDA_74c08046

@emcbot
Copy link

emcbot commented Nov 25, 2024

Experiment C96C48_hybatmDA FAILED on Hera in Build# 8 in
/scratch1/NCEPDEV/global/CI_dh/2943/RUNTESTS/EXPDIR/C96C48_hybatmDA_74c08046

@emcbot
Copy link

emcbot commented Nov 25, 2024

Experiment C48_ATM FAILED on Hera in Build# 8 in
/scratch1/NCEPDEV/global/CI_dh/2943/RUNTESTS/EXPDIR/C48_ATM_74c08046

@emcbot
Copy link

emcbot commented Nov 25, 2024

Experiment C48_S2SWA_gefs FAILED on Hera in Build# 8 in
/scratch1/NCEPDEV/global/CI_dh/2943/RUNTESTS/EXPDIR/C48_S2SWA_gefs_74c08046

@emcbot emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Nov 25, 2024
@emcbot
Copy link

emcbot commented Nov 25, 2024

CI Failed on Hera in Build# 8
Built and ran in directory /scratch1/NCEPDEV/global/CI_dh/2943


Experiment C96C48_hybatmaerosnowDA_74c08046 Terminated with 0
FAIL
FAIL tasks failed and 1 dead at Mon Nov 25 15:23:28 UTC 2024
Experiment C96C48_hybatmaerosnowDA_74c08046 Terminated: *FAIL*
Error logs:
/scratch1/NCEPDEV/global/CI_dh/2943/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA_74c08046/logs/2021122012/gdas_aeroanlgenb.log
Experiment C96_S2SWA_gefs_replay_ics_74c08046 Completed 1 Cycles: *SUCCESS* at Mon Nov 25 16:18:11 UTC 2024

@DavidHuber-NOAA DavidHuber-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Nov 25, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Nov 25, 2024
@emcbot
Copy link

emcbot commented Nov 25, 2024

CI Passed on Hera in Build# 9
Built and ran in directory /scratch1/NCEPDEV/global/CI_dh/2943


Experiment C96_S2SWA_gefs_replay_ics_e5becab5 Completed 1 Cycles: *SUCCESS* at Mon Nov 25 19:06:30 UTC 2024
Experiment C48mx500_3DVarAOWCDA_e5becab5 Completed 2 Cycles: *SUCCESS* at Mon Nov 25 19:18:37 UTC 2024
Experiment C48_ATM_e5becab5 Completed 2 Cycles: *SUCCESS* at Mon Nov 25 19:30:46 UTC 2024
Experiment C96C48_hybatmaerosnowDA_e5becab5 Completed 3 Cycles: *SUCCESS* at Mon Nov 25 20:31:54 UTC 2024
Experiment C48_S2SWA_gefs_e5becab5 Completed 1 Cycles: *SUCCESS* at Mon Nov 25 20:32:59 UTC 2024
Experiment C96_atm3DVar_e5becab5 Completed 3 Cycles: *SUCCESS* at Mon Nov 25 20:37:58 UTC 2024
Experiment C96C48_hybatmDA_e5becab5 Completed 3 Cycles: *SUCCESS* at Mon Nov 25 20:38:00 UTC 2024
Experiment C48_S2SW_e5becab5 Completed 2 Cycles: *SUCCESS* at Mon Nov 25 21:08:27 UTC 2024
Experiment C96C48_ufs_hybatmDA_e5becab5 Completed 3 Cycles: *SUCCESS* at Mon Nov 25 21:38:55 UTC 2024

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit e41eff2 into NOAA-EMC:develop Nov 26, 2024
10 of 11 checks passed
@DavidHuber-NOAA DavidHuber-NOAA mentioned this pull request Nov 26, 2024
Merged
5 tasks
@DavidHuber-NOAA DavidHuber-NOAA deleted the feature/multi-app branch November 26, 2024 19:02
@DavidHuber-NOAA DavidHuber-NOAA mentioned this pull request Dec 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

@aerorahul aerorahul Awaiting requested review from aerorahul aerorahul is a code owner

@EricSinsky-NOAA EricSinsky-NOAA Awaiting requested review from EricSinsky-NOAA

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA Awaiting requested review from TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA is a code owner

Assignees
No one assigned
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check reservable memory on Hercules and Orion Enable RUN-specific APP configurations
4 participants
@DavidHuber-NOAA @emcbot @TerrenceMcGuinness-NOAA @WalterKolczynski-NOAA