Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to override the default account at setup time #3127

Merged
merged 5 commits into from
Dec 2, 2024

Conversation

DavidHuber-NOAA
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA commented Nov 26, 2024

Description

This adds a new option to setup_expt.py, and adds a missing argument to generate_workflows.sh, to allow users to specify which HPC account they wish to use. It also allows users to specify the environmental variable HPC_ACCOUNT at setup time to specify the account. Documentation is updated to note the new feature.

Resolves #3124

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? YES
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

Setup experiments on Hera.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • I have made corresponding changes to the system documentation if necessary

@DavidHuber-NOAA DavidHuber-NOAA changed the title Fix/hpc account Allow users to override the default account at setup time Nov 26, 2024
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for this! Just noting for future thought, the other two variables that I need to change often are HPSS_PROJECT and HOMEDIR, so we may want to think about how to make those modifiable also.

@DavidHuber-NOAA DavidHuber-NOAA merged commit 6b2d84e into NOAA-EMC:develop Dec 2, 2024
6 checks passed
@DavidHuber-NOAA DavidHuber-NOAA mentioned this pull request Dec 2, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create_experiment HPC_ACCOUNT not working
4 participants