Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"save_pp_data" flag doesn't delete data if a plot fails #702

Closed
1 of 3 tasks
jtmims opened this issue Oct 29, 2024 · 1 comment
Closed
1 of 3 tasks

"save_pp_data" flag doesn't delete data if a plot fails #702

jtmims opened this issue Oct 29, 2024 · 1 comment
Assignees
Labels
bug Something isn't working data Issues related to observational or sample model data. framework Issue pertains to the framework code

Comments

@jtmims
Copy link
Collaborator

jtmims commented Oct 29, 2024

Bug Severity

  • 1 = Minor problem that does not affect total framework functionality (e.g., computation error in a POD, problem with logging output, or an issue on a single system
  • 2 = Major problem that affects overall functionality, but that does not occur for all users (e.g., problems installing the framework with a specific Conda version, a framework option that causes one or more PODs to fail, or missing/incompatible Python modules).
  • 3 = Catastrophic problem that occurs frequently for multiple users and/or on multiple systems (e.g.,framework consistently fails to install on multiple systems, or one or more PODs continuously fails after running successfully)

Describe the bug
Currently, the "save_pp_data" flag in the runtime_config json file doesn't matter if the POD has a faulty plot for PODs such as Wheeler_Kiladis or MJO_suite. Since we are trying to implement the MDTF into the workflow of GFDL model development, having lingering pp_data in dirs could become problematic especially when wanting to run a large suite of PODs.

Environment
Describe the system environment:

  • OS: RHEL 8
  • Conda version: 24.7.1
@jtmims jtmims self-assigned this Oct 29, 2024
@jtmims jtmims added bug Something isn't working framework Issue pertains to the framework code data Issues related to observational or sample model data. labels Oct 29, 2024
@jtmims
Copy link
Collaborator Author

jtmims commented Nov 18, 2024

After digging further into output_manager.py, it seems as though the framework was agnostic to the files in the WORK_DIR and would only cleanup .nc files in each POD dir. #710 makes the framework look into the WORK_DIR/OUTPUT_DIR as well.

@jtmims jtmims closed this as completed Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data Issues related to observational or sample model data. framework Issue pertains to the framework code
Projects
None yet
Development

No branches or pull requests

1 participant