Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main to dev (2024-05-13) #630

Merged
merged 8 commits into from
May 14, 2024
Merged

Main to dev (2024-05-13) #630

merged 8 commits into from
May 14, 2024

Commits on Mar 4, 2024

  1. Merge pull request #127 from jiandewang/feature/update-to-main-20240228

    update to main 20240228 commit
    jiandewang authored Mar 4, 2024
    Configuration menu
    Copy the full SHA
    10521a9 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Error cleanup (Intel Fortran)

    This patch clears out many errors detected by Intel Fortran.
    
    Most are false positives from stub functions which would normally be
    replaced in production and report unset output.  These variables are now
    assigned dummy values in order to pacify the compiler.
    
    The `stat` function in POSIX was incorrectly passing its `buf` object to
    the C `stat` function as `intent(in)`, causing the compiler to believe
    that the contents were unset.  Oddly, this was already working
    correctly, and perhaps warrants further investigation, but it has now
    been correctly set to `intent(inout)`.
    
    The `ppoly_*` variables in `check_reconstruction_1d` appear to have been
    incorrectly declared as `out`, when they are clearly used as `in` to
    validate the values.  This has been corrected.
    
    `register_diag_field` in the ice shelf diag manager was incorrectly
    declared and the function appeared to return nothing.  Perhaps this
    function was not used for anything.
    
    An IO statement in MOM_open_boundary had a syntax error; this has been
    fixed.
    
    `get_dataset` returns a `dataset_type`, so some compilers expect the
    stub function to also return a valid `dataset`.  Since the stub
    `dataset_type` contains no fields, any locally declared instance should
    be sufficient as a return value.
    marshallward committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    dc24883 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Merge pull request #130 from marshallward/emc_fix_warn

    Error cleanup (Intel Fortran)
    jiandewang authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    ab7bd14 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Configuration menu
    Copy the full SHA
    6d0150d View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Merge pull request #132 from jiandewang/feature/update-to-main-20240401

    update to MOM6 main repo 20240401 commit
    jiandewang authored Apr 25, 2024
    Configuration menu
    Copy the full SHA
    0730606 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Replace db array default values with real literals

    The default values for the database transfer functions were incorrectly
    assiged as integer literals, recast to types using real32/64 but
    actually corresponding to whatever integer kind equals real32/64.
    
    We now simply assign it a literal value of -1. and rely on the compiler
    to handle the recasting.
    
    Although none of these functions were intended to be used, and -1 would
    probably be eventually cast into an appropriate real type, it is better
    to get this correct.
    
    Thanks to Keith Lindsay for suggesting this change.
    marshallward committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    aac5bb8 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #12 from marshallward/db_type_fix

    Replace db array default values with real literals
    jiandewang authored Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a89d085 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Merge pull request mom-ocean#1623 from jiandewang/DEV-EMC-candidate-2…

    …0240425
    
    remove compiling warning
    jiandewang authored May 8, 2024
    Configuration menu
    Copy the full SHA
    129e1bd View commit details
    Browse the repository at this point in the history