Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions with similar names/method consolidated in definition and location #28

Open
fmalatino opened this issue Sep 29, 2023 · 0 comments

Comments

@fmalatino
Copy link
Contributor

Current functions that fit this category:

compute_eta (defined and called in multiple files)
initialize_delp/_initialize_delp (similar functionality)
initialize_edge_pressure/_initialize_edge_pressure (similar functionality)

I plan to track more of these down and either leave one definition in place or for something like compute_eta, place in a central module that can be imported

fmalatino added a commit that referenced this issue Oct 13, 2023
…(continuous issue) (#30)

* Testing changes reflected across branches

* Undoing changes made in build_gaea_c5.sh

* Testing vscode functionality, by adding a change to external_grid branch

* Testing vscode functionality, by adding a change to external_grid branch

* Edited init_utils.py and initialize_tc.py regarding the overlap in initialize_delp and initialize_edge_pressure functions

---------

Co-authored-by: Frank Malatino <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant