fix for special accumulation case where MASSDEN 0h field ends in '_1' #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshartsough
requested review from
christinaholtNOAA,
Brian-Jamison,
kayeekayee and
jaymes-kenyon
as code owners
Craig added changes that Christina made for new micromamba syntax in graphics_tests here as well.
more changes to hrrr_maps_tests from graphics_tests, missed in last commit
another change from the graphics_tests side that needed to be brought over to hrrr_maps_tests.
taking out some bad syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MASSDEN field (measuring dust) has two variables, one for coarse and one for fine. For the initial hour, one field ends with '_avg' and one with '_avg_1'. For later hours they end in '_avg1h' and '_avg1h_1'.
The pygraf code recognizes the '_avg' and renames the field as needed, but doesn't recognize the '_avg_1' field as needing to be renamed. The error causes the graphics code to completely crash on hour=001.
This change treats the initlal-hour '_avg_1' field separately from the other code logic, and does the necessary renaming.
Tested in the RRFS_B realtime runs for twelve hours, seems to work as desired.
Passed pylint. Will do pytest on PR submission.