Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and rename hook_objects to hook_factories #191

Open
aaraney opened this issue Sep 5, 2024 · 0 comments
Open

Deprecate and rename hook_objects to hook_factories #191

aaraney opened this issue Sep 5, 2024 · 0 comments
Assignees
Labels
ngen.init_config Related to ngen.init_config package

Comments

@aaraney
Copy link
Member

aaraney commented Sep 5, 2024

hook_objects: Collection[BuilderVisitableFn],

Add deprecation warning if hook_objects is used.

I think it’s worth easing future pain by modifying the api to be keyword only too. To my knowledge all uses of this function specify arguments as keywords. I’ll do more investigating before making this breaking change.

@aaraney aaraney added the ngen.init_config Related to ngen.init_config package label Sep 5, 2024
@aaraney aaraney self-assigned this Sep 5, 2024
@aaraney aaraney changed the title Deprecate and rename hook_objects, hook_factories. Deprecate and rename hook_objects to hook_factories Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ngen.init_config Related to ngen.init_config package
Projects
None yet
Development

No branches or pull requests

1 participant