Replay Mover #5
Replay Mover #5
Conversation
timothyas
force-pushed
the
feature/replay-mover
branch
from
e386e73 to
397875a
Compare
|
@danielabdi-noaa could you give this a look and make sure it looks OK to you? @frolovsa it's ready for you to take a look as well whenever you get the chance |
There was a problem hiding this comment.
@timothyas thank you for your contribution. Overall this is very clear. As we discussed in-person. Lets make an issue capturing the idea that some of the hard coded values should be abstracted so the .py code can be reused without editing.
There was a problem hiding this comment.
@timothyas This looks great to me! I have left a few suggestions mostly because I have to :) I understand these are one-off scripts so my suggestions to make them more generic are probably not worth the time. I know what to edit to get it running for my case after our meeting the other day. Thanks!
|
Thanks @frolovsa and @danielabdi-noaa for all of the comments! I definitely agree that we can generalize this. @frolovsa And I talked about merging this without generalizing the behavior as a first pass. I'll raise an issue and we can all agree on the generalizations, and we can implement that in the future. Does that sound good @danielabdi-noaa ? Other than that I'll address some of your detailed comments (thanks for those!) next week when I'm in front of a computer before merging. |
|
@timothyas Yes, that sounds good to me. Happy holidays! |
|
You too @danielabdi-noaa! |
|
@danielabdi-noaa and @frolovsa I addressed your comments either by mentioning the points of generalization in #12 or in the most recent commits. Let me know if you think it's good to go and I'll merge. Thanks again! |
|
@timothyas Looks good to me! Thanks for addressing my suggestions. |
This adds example code to move the 1 degree and 1/4 degree replay datasets. The README.md file contains an overview of what each file does, some notes on performance including what did not work for moving 30 years of 1/4 degree data, and notes on ensuring that access to GCS is secured.
I'll leave this as a draft for now and wait until the 1/4 degree jobs are done to merge. I'll tag people when that happens.