Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kempe edge seals #125

Merged
merged 12 commits into from
Sep 30, 2024
Merged

Kempe edge seals #125

merged 12 commits into from
Sep 30, 2024

Conversation

MDKempe
Copy link
Collaborator

@MDKempe MDKempe commented Sep 17, 2024

Some improvements to the plotting of the oxygen diffusion tool.
Updated some O2 parameters.
Improved the O2 diffusion calculation at the interface.

Kempe and others added 12 commits September 17, 2024 14:50
Updated the PO measurement parameters.
Improved the plotting and the calculations at the interface.
Added in better plotting and some data output functions.
Fixing some problems in the calculation of the interface nodes and modifying it to do a reaction and a degradation calculation.
Modified the Json file access tool.
Modifying the output to show json options.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 63.41463% with 15 lines in your changes missing coverage. Please review.

Project coverage is 66.43%. Comparing base (d8629cf) to head (08d739a).

Files with missing lines Patch % Lines
pvdeg/diffusion.py 61.53% 15 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #125      +/-   ##
===============================================
- Coverage        66.51%   66.43%   -0.09%     
===============================================
  Files               36       36              
  Lines             3396     3420      +24     
===============================================
+ Hits              2259     2272      +13     
- Misses            1137     1148      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martin-springer martin-springer merged commit 0ef212c into development Sep 30, 2024
6 checks passed
@martin-springer martin-springer deleted the Kempe-Edge-Seals branch September 30, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants