Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlinks in uploaded run tar prevents dearchiving #357

Open
TShapinsky opened this issue Sep 23, 2022 · 4 comments
Open

Symlinks in uploaded run tar prevents dearchiving #357

TShapinsky opened this issue Sep 23, 2022 · 4 comments

Comments

@TShapinsky
Copy link
Member

No description provided.

@TShapinsky
Copy link
Member Author

TShapinsky commented Oct 12, 2022

It is fairly easy to tall the python tarfile library to turn symlinks into their target files. However when you do this e+ can no longer find supporting files for running the simulation.

Additionally, to save space we heavily lean on symlinks to system python for our virtual environments.

@TShapinsky
Copy link
Member Author

@axelstudios can you provide more context on what issue you're running into on windows when trying to dearchive runs? I wonder if there may be a different solution to just losing symlinks.

@axelstudios
Copy link
Member

Sure - this is the error you'll see when attempting to extract the contents of a completed runs' .tar.gz archive:
image

That's because it contains serveral symlinks, which require admin rights on Windows to create (and in general you really don't want to be using symlinks on Windows unless you have a great reason):
image

When creating the tarballs it should be easy enough to have it archive actual files instead of symlinks: https://superuser.com/a/137391/1074025

@TShapinsky
Copy link
Member Author

Yeah, I can dereference but it breaks the worker, and also when we have python venvs there are symbolic links to files which are not in the run directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants