-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a user survey on resourcedata.org #268
Comments
Link to draft survey via Google forms: https://docs.google.com/forms/d/e/1FAIpQLScEPUnBIoFTGIiZPFX5Sqj66Xdrw1dm6XR5KjdEBsfl2JDsCA/viewform?usp=sf_link I have taken some questions and inspiration from the data.gov.ie survey. |
Do you want this to run on Google Forms or survey monkey? |
Google Forms unless there is a compelling reason to use survey monkey (is it more reputable?) |
No, clarification. The first message said survey monkey, and the last a google link. |
Right. We will stick with Google Forms, then. |
Hi Tommy. I'm going to be working on the survey implementation tomorrow. I suggest I start with the "definitely" triggers and we'll see how it looks from there. So that will be both ways of triggering a download, using Google Forms. |
@jodiegardiner any progress here? |
I've added a popup to the download buttons on the resource and dataset pages inviting users to fill out the survey and a cookie that will prevent a user being spammed again when they next download a res. Currently with a 30 second expiry time so you can test. http://nrgi.staging.derilinx.com/dataset How often would you like to prompt users to fill out the survey? Once per day? |
@jodiegardiner With Deirdre we discussed them only being offered the survey one time. I think that is OK or else maybe set it for 60 days or something? Do you have a thought? @deirdrelee is there any perspective from the data.gov.ie implementation that would be helpful? Can you also link the site to have a look? I don't see anything on staging.resourcedata.org. Thanks. |
I edited the ticket immediately after posting as I noticed I didn’t put a link, but clearly you are reading my response via email which obviously won’t include that.
http://nrgi.staging.derilinx.com/ is where you want to look.
For data.gov.ie<http://data.gov.ie> the survey is offered again after 24 hours. I have no strong opinion on it either way. It very much depends on what data you are surveying and what you’re using it for.
|
Ok, I see the popup. It looks good! There seems to be an issue for certain types of filetypes though, PDFs specifically. When I click the download button for a document (e.g. here) I do not get the popup. Could be related to how it downloads, because when I use that button in Chrome & Firefox the PDF just opens up right in the browser (same tab). |
I've sorted that now. All downloads now set to target="_blank" which means in the case of PDFs and other file types which want to open in the same browser tab, they will now open in a new tab instead, leaving the survey popup there. It was actually popping up but was being undone by the window moving on to the PDF. |
@jodiegardiner some comments on the modal itself:
|
No problem. And yes, can add it to the url string too as per your previous comment. |
Hey, |
Same |
Let's also do a new tab for the "Yes" button on the modal. And please increase the top margin on the modal-dialog as well, preferably to a point where the header of the modal overlaps somewhat with the main blue navigation bar. |
target="_blank" added to Yes button and to the url string. I added 160px top margin to the dialog. That makes the top of the modal overlap the header bar on the resource page. Let me know if that needs tweaked further. |
Looks great! A final tweak to the body text: "Your feedback is important. Help us improve ResourceData.org by taking a short survey." When I test, it wraps the line after "..ResourceData.org ", if for some reason it returns before "resourcedata.org", please increase the width slightly. |
Made modal a few pixels wider as it did indeed wrap for me. Body text changed as advised. Good to go? |
@jodiegardiner I think it looks great. Final issue we did not settle on: cookies I would like users to be prompted only once. |
With that settled, should we push to staging.resourcedata.org and plan on going live tomorrow or Wednesday? I will just be running the setup past the team here one last time. |
@jodiegardiner some last changes and then let's push to staging.resourcedata.org? Text change on body: "Your feedback is crucial to us." to "Your feedback is important to us." Text change on button: "YES I'LL HELP" to "YES" (keep the button width the same though) |
Hi @moman822 I've implemented those changes. It is not possible to set a cookie to never expire so instead I set it to expire in 10 years, effectively the same thing in this case. I'll push that to staging now. |
And deployment successful. |
So one concern from the team is regarding how for all PDF downloads, the download is just opening the document in a new browser tab and you are redirected automatically to that tab, while the survey prompt opens in the original tab. This could cause people to miss the survey prompt if they just exit the original tab without returning. Are there any fixes possible in this case, like to delay the new tab opening or trigger that only when clicking out of the modal? Or prevent switching to the new tab? |
@jodiegardiner any ideas on the above issue? |
Hi Tommy. My solution was to add the "download" attribute to the anchor if the file format is pdf. This downloads the pdf in the background whilst the survey popup remains in the foreground. I made sure both the resource page and the resource list on the dataset page exhibit this behaviour. |
Note for testing, the cookie has a 10 year expiry so judicial use of incognito windows/cookie purges may be required. |
Hi @jodiegardiner , that sounds like a good solution but I am not seeing it work as described on either staging site. Can you confirm it is working as you've described? Thanks. |
Hi Tommy, I was ccertain I had thoroughly tested this but I got the same behaviour as you today. I did some investigation and the download attribute will only work for same-origin URLs. That's fine and in our case means they'll work just fine BUT if you start on an nrgi.staging.derilinx.com page instead of a http://li1665-139.members.linode.com/ page then we'll encounter that limitation as the browser thinks the origin and the destination are not on the same server. Try the above link to see that in action. |
@jodiegardiner works for me on the download button from the resource page. Can you also add the attribute to the download button from the "Explore" dropdown on the package page? Once that is done, let's push to production and wrap this up! Thanks. |
@jodiegardiner can we finish this up today? |
@jodiegardiner I have just noticed that the incorrect download behavior (new tab opening) is occurring for the RGI documents. Based on your comment above, I guess this is a "same-origin" issue because the RGI docs are hosted on an s3 bucket. Is there a workaround? |
Hmm, I'll have a look. |
Add user testing component: implement redirection to an optional survey to be taken when datasets/documents are downloaded, and provide guidance on survey content.
The text was updated successfully, but these errors were encountered: