Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more drop-in places #17

Open
2 of 4 tasks
mrakitin opened this issue Jan 8, 2021 · 2 comments
Open
2 of 4 tasks

Add more drop-in places #17

mrakitin opened this issue Jan 8, 2021 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mrakitin
Copy link
Member

mrakitin commented Jan 8, 2021

There should be a way to have the following drop-in places:

  • shell:
    • before the main test (already have it, called .ci/bl-specific.sh)
    • after the main test, to be able to run caget, caput, etc.
  • Python:
    • run custom code before running the startup Python files, but after the caproto IOC has started
    • run custom code after running the startup Python files (already exists, called .ci/drop-in.py). It won't be executed in case the prior files loading failed.

We need to define consistent/clear names for those files.

Prompted by NSLS-II-OPLS/profile_collection#10 (comment).

@mrakitin
Copy link
Member Author

mrakitin commented Jan 8, 2021

@jklynch, what would be your suggestions for the names? I am thinking about the following:

  • .ci/pre-test.sh (a new name of .ci/bl-specific.sh)
  • .ci/post-test.sh
  • .ci/pre-test.py
  • .ci/post-test.py (a new name of .ci/drop-in.py)

Should we differentiate the .py files more (e.g., different name, or use underscores, or something else), so that the files are not confused. Maybe a prefix such as shell-pre-test.sh and python-pre-test.py? Too repeating?

@jklynch
Copy link

jklynch commented Jan 8, 2021

pre-test.sh and post-test.sh seem pretty good. Nothing else springs to mind for me.

Would pre-startup.py and post-startup.py make sense for the python scripts? Or pre-ipython-startup.py and post-ipython-startup.py? The second ones are pretty long but descriptive.

@mrakitin mrakitin added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants