New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change profile photo fail #7

Open

daaniikusnanta opened this issue Apr 19, 2023 · 0 comments

Assignees

Labels

bug

Collaborator

daaniikusnanta commented Apr 19, 2023

Changing photo on API Level <21 or the photo is portrait (height > width) will fail

How to reproduce
Changing photo on API Level <21 or the photo is portrait (height > width)

Fixes

On API <21, the app must have WRITE_EXTERNAL and READ_EXTERNAL permission. This is unnecessary on API >=21
Portrait photo will mess up the algorithm for making the photo square. Change the algorithm to check for largest dimension first.

daaniikusnanta self-assigned this

daaniikusnanta added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment