Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/yamaha/320 improvement help page #328

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

hikahana
Copy link
Collaborator

@hikahana hikahana commented Dec 4, 2024

対応Issue

概要

introjsを導入しました

実装詳細

intro.jsを入れてCSSをいい感じに上書きした

画面スクリーンショット等

image
image

テスト項目

  • [ ]初めてアプリを使うときに自動でintro.jsが動くか
  • [ ]ハイライトにズレがないか
  • [ ]説明文(日本語,英語)がおかしくないか

備考

@github-actions github-actions bot added frontend bug Something isn't working labels Dec 4, 2024
"リーチしたらこのボタンを押してください!<br>みんなのリーチ数がスクリーン上に表示されます!",
page5_title: "設定ボタン",
page5_txt: "このボタンを押すと番号の表示順や言語を変更できます!",
next: "次へ",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

helpCarouselに同じようなのあるのでどっちかにしたいですね

page5_title: "Settings Button",
page5_txt:
"Press this button to change the number display order and language!",
next: "Next",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここも同様

@@ -7,6 +7,7 @@ interface IconFrameworkProps {
text: string;
outline?: boolean;
inversion?: boolean;
id?: string;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idってstringにしたのは意図ありますか?
intでも良いかも?introの仕様的にstringならこのままでokです
匙加減分かりませんが

@@ -31,3 +31,16 @@
.logo path:nth-child(2) {
fill: var(--main-color);
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一応コメントつけますか。
// note introjsのcssをカスタムで指定できないためimportantを使う

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ヘルプページの改良
2 participants