Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] validate_yaml() isn't in sync with arguments check #1297

Open
pierric opened this issue Nov 21, 2024 · 0 comments
Open

[BUG] validate_yaml() isn't in sync with arguments check #1297

pierric opened this issue Nov 21, 2024 · 0 comments

Comments

@pierric
Copy link

pierric commented Nov 21, 2024

Describe the bug
This check isn't in sync with the one in the arguments.py

To Reproduce

  • in yaml config, pipeline_model_parallel_size = 2, and num_layers_per_virtual_pipeline_stage = 2
  • pass --yaml-cfg

Expected behavior
The setting pipeline_model_parallel_size = 2 should be accepted.

Proposed fix
sync up the check in the two places.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pierric