minor fixes

NVIDIA · Jun 19, 2024 · 060e0ef · 060e0ef
1 parent 5ba6830
commit 060e0ef
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/nemo_skills/finetuning/data_preparation_utils/filters.py b/nemo_skills/finetuning/data_preparation_utils/filters.py
@@ -35,13 +35,9 @@ class BaseFilter(BaseParallelProcessor):
     def __init__(self, **kwargs):
         super().__init__(**kwargs)
 
-    def process_dataset_entry(self, data_entry) -> List:
-        raise NotImplementedError
-
     def test(self):
-        cached_value, self.should_apply = self.should_apply, True
-        super().test()
-        self.should_apply = cached_value
+        if self.should_apply:
+            super().test()
 
 
 class DropMultiBoxed(BaseFilter):