-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDP data preparation pipeline #37
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kipok
requested changes
Jun 12, 2024
i-vainn
force-pushed
the
imoshkov/sdp_pipeline
branch
from
June 14, 2024 17:51
7b85475
to
7e962d8
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…Mo-Skills into imoshkov/sdp_pipeline
Kipok
requested changes
Jun 15, 2024
nemo_skills/finetuning/data_preparation_utils/sdp_configs/openmathinstruct_config.yaml
Outdated
Show resolved
Hide resolved
nemo_skills/finetuning/data_preparation_utils/sdp_configs/openmathinstruct_config.yaml
Outdated
Show resolved
Hide resolved
Kipok
reviewed
Jun 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow I'm getting more entries when running the new script. Can it be that we don't deduplicate properly?
i-vainn
force-pushed
the
imoshkov/sdp_pipeline
branch
from
June 19, 2024 20:03
b8b9a11
to
060e0ef
Compare
for more information, see https://pre-commit.ci
Kipok
approved these changes
Jun 26, 2024
Looks great, let's merge this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
nemo-skills/finetuning/prepare_sft_data.py
to SDP pipeline