Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDP data preparation pipeline #37

Merged
merged 27 commits into from
Jun 27, 2024
Merged

Conversation

i-vainn
Copy link
Collaborator

@i-vainn i-vainn commented Jun 12, 2024

Changed nemo-skills/finetuning/prepare_sft_data.py to SDP pipeline

@i-vainn i-vainn requested a review from Kipok June 12, 2024 00:00
nemo_skills/code_execution/math_grader.py Outdated Show resolved Hide resolved
nemo_skills/inference/server/sync.py Outdated Show resolved Hide resolved
pipeline/launcher.py Outdated Show resolved Hide resolved
pipeline/run_pipeline.py Outdated Show resolved Hide resolved
tests/gpu-tests/test_server.py Outdated Show resolved Hide resolved
nemo_skills/finetuning/prepare_sdp.py Outdated Show resolved Hide resolved
nemo_skills/finetuning/data_preparation_utils/filters.py Outdated Show resolved Hide resolved
nemo_skills/finetuning/data_preparation_utils/filters.py Outdated Show resolved Hide resolved
nemo_skills/finetuning/data_preparation_utils/filters.py Outdated Show resolved Hide resolved
@i-vainn i-vainn force-pushed the imoshkov/sdp_pipeline branch from 7b85475 to 7e962d8 Compare June 14, 2024 17:51
nemo_skills/finetuning/prepare_sdp.py Outdated Show resolved Hide resolved
nemo_skills/finetuning/prepare_sdp.py Outdated Show resolved Hide resolved
nemo_skills/finetuning/prepare_sdp.py Outdated Show resolved Hide resolved
nemo_skills/finetuning/prepare_sdp.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Kipok Kipok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow I'm getting more entries when running the new script. Can it be that we don't deduplicate properly?

nemo_skills/finetuning/data_preparation_utils/filters.py Outdated Show resolved Hide resolved
@i-vainn i-vainn force-pushed the imoshkov/sdp_pipeline branch from b8b9a11 to 060e0ef Compare June 19, 2024 20:03
@Kipok
Copy link
Collaborator

Kipok commented Jun 26, 2024

Looks great, let's merge this!

@Kipok Kipok merged commit ccec8d2 into NVIDIA:main Jun 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants