Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support For Applying Patches #25

Open
fifofonix opened this issue Apr 25, 2024 · 2 comments
Open

Add Support For Applying Patches #25

fifofonix opened this issue Apr 25, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@fifofonix
Copy link
Contributor

For OS versions without official support, e.g. FedoraCoreOS, it may sometimes (^1) be necessary to apply an NVIDIA-forum-recommended patch(es) to overcome compilation issues to deliver a working environment. The current driver container does not expose a means to easily apply patches via the installer's --apply-patch switch.

Having a means toinit the driver-container with an --apply-patches switch that searched a specified directory for applicable patches would be a convenience feature for teams running non-supported OS versions. In the situation where the driver container is running on the host one could imagine mounting patches to the container via systemd units etc. However, this method might not extend easily to a gpu-operator scheduled driver container (whether there exists an injection point for a) additional command switches, b) additional config files into the k8s/gpu-operator scheduled driver pods needs investigation).

^1 For at least a month it has been known that driver compilation for Fedora40 (which was in beta at the time, but is now released) fails affecting anyone running environments based on FedoraCoreOS's next and now testing streams. It is expected that in two weeks unless a formal new driver version is released incorporating the patch, that these failures will migrate to the FedoraCoreOS stable stream.

@cdesiniotis cdesiniotis added the enhancement New feature or request label Apr 26, 2024
@cdesiniotis
Copy link
Contributor

@fifofonix thanks for raising this RFE. I agree that it would be helpful if we exposed an interface for passing additional command line options to the nvidia installer. PRs are always welcome if you are interested in contributing this.

Concerning your second request -- mounting arbitrary config files to the GPU Operator managed driver container -- we would need to evaluate further. cc @shivamerla @tariq1890

@fifofonix
Copy link
Contributor Author

fifofonix commented May 10, 2024

Note I have a work-in-progress pull request for fedora that allows a single patch to be applied to the driver container. With this feature it is possible to get a working fedora40 driver container by applying a specific patch referenced originally on the NVIDIA driver forum. When I say work-in-progress pull request, I mean I have completed a merge request on GitLab in the referenced project.

https://gitlab.com/container-toolkit-fcos/driver/-/issues/11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants