New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stepbytes (increment size) argument does not support 1M notation #225

Open

StefanoSalsano opened this issue Jun 14, 2024 · 1 comment

Contributor

StefanoSalsano commented Jun 14, 2024

the documentation of the stepbytes argument says:
-i,--stepbytes fixed increment between sizes. Default : 1M

actually, if you run this command
.build/all_reduce_perf -b 64M -e 70M -i 2M -g 1

the increment is not parsed as 2M but as 2 bytes, which is quite unexpected

I will open a pull request to fix this annoying behavior

StefanoSalsano mentioned this issue

improve parsing of stepbytes (increment size) argument #226

Merged

Contributor Author

StefanoSalsano commented Jun 14, 2024

I have submitted pull request #226 to fix the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment