Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules Folder Clean-Up #198

Open
willykaram opened this issue Mar 23, 2014 · 6 comments
Open

Modules Folder Clean-Up #198

willykaram opened this issue Mar 23, 2014 · 6 comments
Labels

Comments

@willykaram
Copy link
Member

I just notices that our sites/all/modules folder is a bit jumbled. We don't have a separate folder for /contrib vs/custom modules. I would like to fix that quickly in the course of some other work. Does anyone object?

@ForestMars
Copy link
Contributor

I'm pretty sure you'l need to rebuild the registry after you do that.

@rabellamy
Copy link
Contributor

@willykaram do it!!!

@likewhoa
Copy link
Contributor

likewhoa commented Apr 5, 2014

remember this will require the rr drush filter enabled on @LiVe so that the registry is rebuild properly. This should be tested in @test and QA fully by that make sure that all functionality is working. This issue also relates to my #16 issue which we should do first.

@likewhoa likewhoa added the task label Apr 5, 2014
@willykaram
Copy link
Member Author

If people still think we should do this, then I can do so late tonight. My concern is that it's going to make quite a few updates to everyone's branches, and we should ensure that everyone is on board with this.

I will implement this on a separate branch/multidev and test thoroughly before implementing on live. I think that this is pretty much the last day when we can do this. After today, I'd rather not undertake this change as it's too close to the camp.

FWIW, at this point, I think we could just leave it as is until after the camp. As this is really a behind the scenes change that we're making for best practices purposes, but that doesn't have any UX or other benefit for camp attendees.

Perhaps @esod and @mirie and others can also weigh in

@esod
Copy link
Contributor

esod commented Apr 5, 2014

Don't do this. It's really not necessary. Leave the modules folder as it is. We can get to this after the camp.

@willykaram
Copy link
Member Author

I agree with Eric's comment right now. Unless anyone strongly objects, let's defer on this until after the camp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants