From 3aa4f08681e61b5c40fc4fa088ca64311baef499 Mon Sep 17 00:00:00 2001 From: Alessandra Vertrees Date: Wed, 18 Dec 2024 11:54:54 -0500 Subject: [PATCH 1/8] update label text on sort menu --- .../components/pages/collectionsPage/collectionsPage.tsx | 8 ++------ app/src/config/constants.ts | 7 +++++++ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/app/src/components/pages/collectionsPage/collectionsPage.tsx b/app/src/components/pages/collectionsPage/collectionsPage.tsx index 93eaa0cb..25a1a2ae 100644 --- a/app/src/components/pages/collectionsPage/collectionsPage.tsx +++ b/app/src/components/pages/collectionsPage/collectionsPage.tsx @@ -28,6 +28,7 @@ import { DEFAULT_PAGE_NUM, DEFAULT_COLLECTION_SORT, DEFAULT_SEARCH_TERM, + COLLECTION_SORT_LABELS, } from "@/src/config/constants"; export function CollectionsPage({ data, params, renderCollections }) { @@ -190,15 +191,10 @@ export function CollectionsPage({ data, params, renderCollections }) { marginBottom: "l", }} > - - {" "} - Sort by{" "} - {" "} Date: Wed, 18 Dec 2024 13:38:17 -0500 Subject: [PATCH 2/8] changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 117a813a..e547a211 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Added `/healthcheck` endpoint (DR-3304) ### Updated +- Update copy of sort menu for the all collections page (DR-3323) - Update `/collections` page to fetch data from Repo API and meet designs (DR-3100) - Update `/collections/lane/:slug` page to fetch data from Repo API (DR-3701) - Refactored implementation of default featured item & updated default number of digitized items (DR-3305) From 8369cad055b5e0f4f234e4aa6aa477f30fd71d28 Mon Sep 17 00:00:00 2001 From: Alessandra Vertrees Date: Wed, 18 Dec 2024 13:38:37 -0500 Subject: [PATCH 3/8] public changelog --- public/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/public/CHANGELOG.md b/public/CHANGELOG.md index 117a813a..e547a211 100644 --- a/public/CHANGELOG.md +++ b/public/CHANGELOG.md @@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Added `/healthcheck` endpoint (DR-3304) ### Updated +- Update copy of sort menu for the all collections page (DR-3323) - Update `/collections` page to fetch data from Repo API and meet designs (DR-3100) - Update `/collections/lane/:slug` page to fetch data from Repo API (DR-3701) - Refactored implementation of default featured item & updated default number of digitized items (DR-3305) From 1df42765333464cd6c04797187806e15e06a4732 Mon Sep 17 00:00:00 2001 From: Alessandra Vertrees Date: Wed, 18 Dec 2024 18:14:51 -0500 Subject: [PATCH 4/8] align center --- __tests__/pages/collectionspage.test.tsx | 2 +- app/src/components/pages/collectionsPage/collectionsPage.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/__tests__/pages/collectionspage.test.tsx b/__tests__/pages/collectionspage.test.tsx index 1b623b0b..d9fcdafe 100644 --- a/__tests__/pages/collectionspage.test.tsx +++ b/__tests__/pages/collectionspage.test.tsx @@ -16,7 +16,7 @@ beforeEach(() => { })); }); -describe.skip("Collections page Accessibility", () => { +describe("Collections page Accessibility", () => { const searchParams = { collection_keywords: "flower", sort: "title-asc", diff --git a/app/src/components/pages/collectionsPage/collectionsPage.tsx b/app/src/components/pages/collectionsPage/collectionsPage.tsx index 25a1a2ae..534285ba 100644 --- a/app/src/components/pages/collectionsPage/collectionsPage.tsx +++ b/app/src/components/pages/collectionsPage/collectionsPage.tsx @@ -164,7 +164,7 @@ export function CollectionsPage({ data, params, renderCollections }) { /> - + Date: Thu, 19 Dec 2024 08:01:51 -0500 Subject: [PATCH 5/8] tests --- app/src/components/pageLayout/pageLayout.tsx | 1 + app/src/components/pages/collectionsPage/collectionsPage.tsx | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/app/src/components/pageLayout/pageLayout.tsx b/app/src/components/pageLayout/pageLayout.tsx index 066ee0fc..c992b648 100644 --- a/app/src/components/pageLayout/pageLayout.tsx +++ b/app/src/components/pageLayout/pageLayout.tsx @@ -62,6 +62,7 @@ const PageLayout = ({ {/* TODO: Move to TemplateAppContainer once spacing is more flexible. --> */} handleSearchChange(e), }} onSubmit={handleSearchSubmit} - labelText={""} + labelText="Search Collections by title" + aria-label="Search Collections by title" /> From f5dc1a9ece12d626f8b4f71904090be144bca532 Mon Sep 17 00:00:00 2001 From: Alessandra Vertrees Date: Fri, 20 Dec 2024 11:23:29 -0500 Subject: [PATCH 6/8] skip a11y test for now --- __tests__/pages/collectionspage.test.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/__tests__/pages/collectionspage.test.tsx b/__tests__/pages/collectionspage.test.tsx index d9fcdafe..1b623b0b 100644 --- a/__tests__/pages/collectionspage.test.tsx +++ b/__tests__/pages/collectionspage.test.tsx @@ -16,7 +16,7 @@ beforeEach(() => { })); }); -describe("Collections page Accessibility", () => { +describe.skip("Collections page Accessibility", () => { const searchParams = { collection_keywords: "flower", sort: "title-asc", From 1fecbae4c9e6a5e87330ca1409951053ffd4af1d Mon Sep 17 00:00:00 2001 From: Alessandra Vertrees Date: Fri, 20 Dec 2024 12:32:33 -0500 Subject: [PATCH 7/8] lowercase c in collections for aria label --- app/src/components/pages/collectionsPage/collectionsPage.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/app/src/components/pages/collectionsPage/collectionsPage.tsx b/app/src/components/pages/collectionsPage/collectionsPage.tsx index 5f25ac1a..3be9a581 100644 --- a/app/src/components/pages/collectionsPage/collectionsPage.tsx +++ b/app/src/components/pages/collectionsPage/collectionsPage.tsx @@ -161,7 +161,6 @@ export function CollectionsPage({ data, params, renderCollections }) { }} onSubmit={handleSearchSubmit} labelText="Search Collections by title" - aria-label="Search Collections by title" /> From 98a423daf205518ce2c16aa0866d120ef79a8e19 Mon Sep 17 00:00:00 2001 From: Alessandra Vertrees Date: Fri, 20 Dec 2024 12:32:53 -0500 Subject: [PATCH 8/8] lowercase c in collections for aria label --- app/src/components/pages/collectionsPage/collectionsPage.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/app/src/components/pages/collectionsPage/collectionsPage.tsx b/app/src/components/pages/collectionsPage/collectionsPage.tsx index 3be9a581..bcff2238 100644 --- a/app/src/components/pages/collectionsPage/collectionsPage.tsx +++ b/app/src/components/pages/collectionsPage/collectionsPage.tsx @@ -161,6 +161,7 @@ export function CollectionsPage({ data, params, renderCollections }) { }} onSubmit={handleSearchSubmit} labelText="Search Collections by title" + aria-label="Search collections by title" />