diff --git a/src/components/featuredContent/featuredContent.test.tsx b/src/components/featuredContent/featuredContent.test.tsx index 9e3ac09f..a0893bf8 100644 --- a/src/components/featuredContent/featuredContent.test.tsx +++ b/src/components/featuredContent/featuredContent.test.tsx @@ -13,10 +13,6 @@ describe("Featured Content component renders with expected props", () => { "src", "/pd_banner.png" ); - expect(within(component).getByRole("img")).toHaveAttribute( - "alt", - "Public Domain banner" - ); const button = within(component).getByTestId("featured-learn-more"); expect(button).toHaveAttribute("href", "https://publicdomain.nypl.org"); @@ -34,10 +30,6 @@ describe("Featured Content component renders with expected props", () => { "src", "/service-artehouse.jpg" ); - expect(within(component).getByRole("img")).toHaveAttribute( - "alt", - "Service Artehouse banner" - ); const button = within(component).getByTestId("featured-visit-store"); expect(button).toHaveAttribute( diff --git a/src/components/featuredContent/featuredContent.tsx b/src/components/featuredContent/featuredContent.tsx index 89efeae6..6982b029 100644 --- a/src/components/featuredContent/featuredContent.tsx +++ b/src/components/featuredContent/featuredContent.tsx @@ -26,7 +26,7 @@ const FeaturedContentComponent = ({ randomNumber }) => { data-testid={data.buttonId} isUnderlined={false} target="_blank" - aria-label={data.ariaLabel} + aria-label={`${data.buttonText}, ${data.heading}`} type="buttonPrimary" > {data.buttonText} @@ -34,7 +34,7 @@ const FeaturedContentComponent = ({ randomNumber }) => { } imageProps={{ - alt: data.imgAlt, + alt: "", width: "oneHalf", position: "end", src: data.imgSrc, diff --git a/src/components/hero/campaignHeroSubText.tsx b/src/components/hero/campaignHeroSubText.tsx index 854a4e0f..15f82f75 100644 --- a/src/components/hero/campaignHeroSubText.tsx +++ b/src/components/hero/campaignHeroSubText.tsx @@ -36,7 +36,14 @@ const CampaignHeroSubText = ({ featuredItem }: any) => { - + Featured Image:{" "} - + strategy="beforeInteractive" + > ); diff --git a/src/pages/index.tsx b/src/pages/index.tsx index 315602d5..ca267774 100644 --- a/src/pages/index.tsx +++ b/src/pages/index.tsx @@ -1,5 +1,8 @@ import CampaignHero from "../components/hero/campaignHero"; -import { TemplateAppContainer } from "@nypl/design-system-react-components"; +import { + SkipNavigation, + TemplateAppContainer, +} from "@nypl/design-system-react-components"; import Header from "@/components/header/header"; import HomePageMainContent from "@/components/homePageMainContent/homePageMainContent"; import ExploreFurther from "@/components/exploreFurther/exploreFurther"; @@ -8,13 +11,18 @@ import NotificationBanner from "@/components/notificationBanner/notificationBann export default function Home(props: any = {}) { return ( <> + {/** * * @TODO: Header will need to be pulled into a reusable Layout component (DC Facelift phase 2) * * Let this be @7emansell 's problem if possible **/}
} + breakout={ +
+ +
+ } contentPrimary={} />