Skip to content

Commit

Permalink
Merge pull request #443 from NYPL/SFR-1779_fix_incorrect_prod_args
Browse files Browse the repository at this point in the history 
SFR-1779: Fix incorrect prod args
  • Loading branch information
@jackiequach
jackiequach authored Sep 8, 2023
2 parents 9f797d3 + 3baa93c commit 3ff31ee
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build-production.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ jobs:
--build-arg NEW_RELIC_LICENSE_KEY=$NEW_RELIC_LICENSE_KEY \
--build-arg NEXT_PUBLIC_ADOBE_ANALYTICS="https://assets.adobedtm.com/1a9376472d37/8519dfce636d/launch-672b7e7f98ee.min.js" .
docker push $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG
docker tag $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG $ECR_REGISTRY/$ECR_REPOSITORY:latest
docker push $ECR_REGISTRY/$ECR_REPOSITORY:latest
docker tag $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG $ECR_REGISTRY/$ECR_REPOSITORY:production-latest
docker push $ECR_REGISTRY/$ECR_REPOSITORY:production-latest
- name: Force ECS Update
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build-qa.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ jobs:
--build-arg NEW_RELIC_LICENSE_KEY=$NEW_RELIC_LICENSE_KEY \
--build-arg NEXT_PUBLIC_ADOBE_ANALYTICS="https://assets.adobedtm.com/1a9376472d37/8519dfce636d/launch-bf8436264b01-development.min.js" .
docker push $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG
docker tag $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG $ECR_REGISTRY/$ECR_REPOSITORY:latest
docker push $ECR_REGISTRY/$ECR_REPOSITORY:latest
docker tag $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG $ECR_REGISTRY/$ECR_REPOSITORY:qa-latest
docker push $ECR_REGISTRY/$ECR_REPOSITORY:qa-latest
- name: Force ECS Update
run: |
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# CHANGE LOG

- Update production and qa builds to use unique ECR image tag

## [0.17.4]

- Add id as subsection for "Read Online" CTA analytics tracking
Expand Down

1 comment on commit 3ff31ee

@vercel
Copy link

@vercel vercel bot commented on 3ff31ee Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

sfr-bookfinder-front-end – ./

sfr-bookfinder-front-end-git-development-nypl.vercel.app
sfr-bookfinder-front-end-nypl.vercel.app
sfr-bookfinder-front-end.vercel.app

Please sign in to comment.