From e1b68b8afdb885722a83742f968492996fb41d49 Mon Sep 17 00:00:00 2001 From: Jackie Quach Date: Thu, 9 Nov 2023 15:00:09 -0500 Subject: [PATCH 1/3] remove collection alt text --- CHANGELOG.md | 3 ++- src/components/CollectionCard/CollectionCard.tsx | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 615bd7ab..8f8e95bc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,7 +12,8 @@ - SFR-1797: Remove Playwright tests with clicks on header and footer links - Update README with C4 diagrams and epub-to-webpub info - Update Collection, Edition, and Work page titles for accessibility -- Implement Typography changes from Reservoir 2.0 +- Implement Typography changes from Reservoir 2.0 +- Remove collection image alt text ## [0.17.4] diff --git a/src/components/CollectionCard/CollectionCard.tsx b/src/components/CollectionCard/CollectionCard.tsx index 3b367cfe..62b0959c 100644 --- a/src/components/CollectionCard/CollectionCard.tsx +++ b/src/components/CollectionCard/CollectionCard.tsx @@ -24,7 +24,7 @@ export const CollectionCard: React.FC<{ collection: Opds2Feed }> = ({ layout="column" imageProps={{ src: PLACEHOLDER_LINK, - alt: `Cover for ${collection.metadata.title}`, + alt: ``, aspectRatio: "twoByOne", }} mainActionLink={collection.links[0].href} From 66519a905266aae719680c988cdac89554ae87dc Mon Sep 17 00:00:00 2001 From: Jackie Quach Date: Thu, 9 Nov 2023 15:17:51 -0500 Subject: [PATCH 2/3] update test --- src/components/CollectionCard/CollectionCard.test.tsx | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/components/CollectionCard/CollectionCard.test.tsx b/src/components/CollectionCard/CollectionCard.test.tsx index 6cf2b8f0..e3d145d0 100644 --- a/src/components/CollectionCard/CollectionCard.test.tsx +++ b/src/components/CollectionCard/CollectionCard.test.tsx @@ -20,11 +20,7 @@ describe("Collection list", () => { ).toBeInTheDocument(); }); test("Shows cover", () => { - expect( - screen - .getByAltText("Cover for Baseball: A Collection by Mike Benowitz") - .closest("img").src - ).toEqual( + expect(screen.getByAltText("").closest("img").src).toEqual( "https://drb-files-qa.s3.amazonaws.com/misc/collectionPlaceholder.jpg" ); }); From 25cec2277280b5e2175250bf0a0756ae5d251ff5 Mon Sep 17 00:00:00 2001 From: Jackie Quach Date: Thu, 9 Nov 2023 15:35:00 -0500 Subject: [PATCH 3/3] increase test timeout --- src/__tests__/Search.test.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/__tests__/Search.test.tsx b/src/__tests__/Search.test.tsx index 1b00ddfa..0a364ce0 100644 --- a/src/__tests__/Search.test.tsx +++ b/src/__tests__/Search.test.tsx @@ -228,7 +228,7 @@ describe("Renders Search Results Page", () => { name: "English (6)", }); expect(englishCheckbox2).toBeChecked(); - }, 15000); + }, 20000); }); describe("Format filter", () => { test("Clicking new format sends new search", async () => {