Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EKIRJASTO-102 Improve contrast in catalog filter buttons #77

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

EKIRJASTO-102 Improve contrast in catalog filter buttons #77

wants to merge 2 commits into from

Conversation

natlibfi-ptalosel
Copy link
Contributor

What's this do?

  • User can see the filter buttons (buttons with titles "All", "Audiobooks" and "eBooks") in Browse books view more easily
    • the contrast was increased in the button group above the book catalog
    • the selected button stands out more clearly from the non-selected buttons
  • The appearance of the segmented control was updated
    • only color changes were made: the background color of normal segments was darkened

Why are we doing this?

  • To improve app's accessibility

How should this be tested?

  • Test E-kirjasto app with device's normal and dark mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natlibfi-psams natlibfi-psams Awaiting requested review from natlibfi-psams

@NatLibFi-JoonaKupe NatLibFi-JoonaKupe Awaiting requested review from NatLibFi-JoonaKupe

@natlibfi-burger natlibfi-burger Awaiting requested review from natlibfi-burger

@natlibfi-kaisa natlibfi-kaisa Awaiting requested review from natlibfi-kaisa

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@natlibfi-ptalosel