Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with nx affected for test / build executors #32

Open
AgentEnder opened this issue Jul 20, 2021 · 1 comment
Open

Compatibility with nx affected for test / build executors #32

AgentEnder opened this issue Jul 20, 2021 · 1 comment

Comments

@AgentEnder
Copy link
Contributor

AgentEnder commented Jul 20, 2021

Current behavior

The current setup fails when running the following:

  • nx run {my-app}:build
  • nx affected:build
  • nx affected --target build

Expected Behavior

The above succeed.

Notes

This is partially due to the setup of ios / android targets that pull config from the actual build target, which does not work on its own. This target should be made to work (possibly by invoking a webpack-only build), and then the ios / android targets could invoke it.

If the ios / android targets could consume a webpack-only build, then their executor could use targetDependencies to require the regular build target be hit first, and not have to do a separate webpack build for android and ios.

@NathanWalker
Copy link
Contributor

Noting here to also include a generator to add the {N} unit test runner with proper test target which would also work with affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants