Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add this official package to npmjs.com #173

Open
hsluoyz opened this issue Jan 19, 2020 · 7 comments
Open

Please add this official package to npmjs.com #173

hsluoyz opened this issue Jan 19, 2020 · 7 comments

Comments

@hsluoyz
Copy link

hsluoyz commented Jan 19, 2020

I saw someone is sending PR/working on it. Please review them and merge them if OK. Thanks!

I saw this one: https://github.com/mercmobily/js-interpreter but I think it's better to put all stuff in this repo. Why can't we do this?

@mercmobily
Copy link

I respectfully and humbly disagree. By using the other repo, you have encountered ad edge case while using Webpack + Typescript. In your issue here https://github.com/mercmobily/js-interpreter/issues you vaguely outline the issue, and then state that "don't have much time to make a full example". I have a proposed solution for your case (based on other solutions of other package maintainers who had similar problems); please let me know if it works for you -- or if you prefer to use a fork that is 112 commits behind the official interpreter (and 29 forking commits that won't merge).

This is precisely why I think keeping things separate is better. I will be more than happy to deal with problems/improvements/edge cases for the distributed version. I am also planning on providing a ES5 minified version.

Let's leave the JS-Interpreter team in peace, getting the real stuff done.

@foxt
Copy link

foxt commented May 4, 2021

I do think providing an NPM package is helpful, as from what I can see, Node.js is a supported runtime and it would make it a lot easier for Node.js users to implement this package.

@hsluoyz
Copy link
Author

hsluoyz commented May 4, 2021

DELETED

So closed here.

@hsluoyz hsluoyz closed this as completed May 4, 2021
@cpcallen
Copy link
Collaborator

cpcallen commented May 4, 2021

Thanks for taking matters in to your own hands, @hsluoyz, but I'm going to reopen this as I concur that there should be an official package.

@cpcallen cpcallen reopened this May 4, 2021
@mercmobily
Copy link

mercmobily commented May 5, 2021 via email

@mercmobily
Copy link

@hsluoyz I just realised, after writing this, that your npm package is based on a git repo which is a fork of aminmarashi-binary/JS-Interpreter. With all due respect, I am not 100% sure this is a good route: having an official repo which is a form of a derivative of the js-interpreter.

@hsluoyz
Copy link
Author

hsluoyz commented May 5, 2021

@mercmobily hi, currently I'm not working on this project related stuff any more. And at that time (1 year ago), I just resolved my issue by forking and releasing my own package for myself to use. Sorry if it misleads you guys into something that I forked the project to be a new "official" and "maintained" one. I have deleted my comment at: #173 (comment)

Generally, I hope the project owner will release an official NPM package. But it's a decision to be made by the owner.

Recently I'm not working on related stuff any more. I tried to close this issue but it's opened again by someone:) Feel free to use this issue to track the progress and allow to drop me in this conversation (aka without AT me), as I will also unsubscribe myself from this issue. Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants