-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please add this official package to npmjs.com #173
Comments
I respectfully and humbly disagree. By using the other repo, you have encountered ad edge case while using Webpack + Typescript. In your issue here https://github.com/mercmobily/js-interpreter/issues you vaguely outline the issue, and then state that "don't have much time to make a full example". I have a proposed solution for your case (based on other solutions of other package maintainers who had similar problems); please let me know if it works for you -- or if you prefer to use a fork that is 112 commits behind the official interpreter (and 29 forking commits that won't merge). This is precisely why I think keeping things separate is better. I will be more than happy to deal with problems/improvements/edge cases for the distributed version. I am also planning on providing a ES5 minified version. Let's leave the JS-Interpreter team in peace, getting the real stuff done. |
I do think providing an NPM package is helpful, as from what I can see, Node.js is a supported runtime and it would make it a lot easier for Node.js users to implement this package. |
DELETED So closed here. |
Thanks for taking matters in to your own hands, @hsluoyz, but I'm going to reopen this as I concur that there should be an official package. |
I feel it would be worthwhile for me to pick in.
I also think that there should be an official NPM package.
Please note that at the moment:
https://github.com/aminmarashi-binary/JS-Interpreter#readme (NPM:
js-jnterpreter)
This is a packaged version of the js-interpreter. I had discussions with
the author, pointing out that having a fork was a bad idea. He agreed, and
stopped being a fork -- instead, all he does is have the js-interpreter
repository as a sub-module, and uses it to 1) Add some CLI features (which
are actually quite nice) 2) builds it so that it's ready to use
https://github.com/mobily-enterprises/js-interpreter (NPM:
js-interpreter-npm)
This is the one that was hopefully going to become the official package,
if aminmarashi-binary/JS-Interpreter hadn't stopped having an old fork.
When he changed that policy, and stopped being a fork, there was less of a
need for an "official" package. mobily-enterprises/js-interpreter (my
repository) has a much simpler approach to packaging than the other one, it
doesn't "build" it... it does very little
I am happy with whatever. I am in no way attached to any possible course. I
will keep the package js-interpreter-npm since I use it for my own
projects. However, I am happy to rename it if it causes confusion.
I do recommend you get in touch with the maintainer
of aminmarashi-binary/JS-Interpreter so that he's involved too. He's great
to talk to.
I hope this helps!
…On Tue, 4 May 2021 at 21:19, Christopher Allen ***@***.***> wrote:
Thanks for taking matters in to your own hands, @hsluoyz
<https://github.com/hsluoyz>, but I'm going to reopen this as I concur
that there should be an official package.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#173 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQHWXW4XTTZSN54EHVZ753TL7X4NANCNFSM4KIXAU7Q>
.
|
@hsluoyz I just realised, after writing this, that your npm package is based on a git repo which is a fork of aminmarashi-binary/JS-Interpreter. With all due respect, I am not 100% sure this is a good route: having an official repo which is a form of a derivative of the js-interpreter. |
@mercmobily hi, currently I'm not working on this project related stuff any more. And at that time (1 year ago), I just resolved my issue by forking and releasing my own package for myself to use. Sorry if it misleads you guys into something that I forked the project to be a new "official" and "maintained" one. I have deleted my comment at: #173 (comment) Generally, I hope the project owner will release an official NPM package. But it's a decision to be made by the owner. Recently I'm not working on related stuff any more. I tried to close this issue but it's opened again by someone:) Feel free to use this issue to track the progress and allow to drop me in this conversation (aka without AT me), as I will also unsubscribe myself from this issue. Thank you all! |
I saw someone is sending PR/working on it. Please review them and merge them if OK. Thanks!
I saw this one: https://github.com/mercmobily/js-interpreter but I think it's better to put all stuff in this repo. Why can't we do this?
The text was updated successfully, but these errors were encountered: