Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onInstalling doesn't seem to be called, because ignoreInstalling is always true #495

Open
julienw opened this issue Mar 22, 2021 · 0 comments
Open

onInstalling doesn't seem to be called, because ignoreInstalling is always true #495

julienw opened this issue Mar 22, 2021 · 0 comments

Comments

@julienw
Copy link
Contributor

julienw commented Mar 22, 2021

Hey!
Thanks for this great package.

I noticed that onInstalling isn't called, it looks like ignoreInstalling is set to true and then never changed.
See

offline-plugin/tpls/runtime-template.js

Line 56 in 2b51a89

ignoreInstalling = true;

Is there a way to set this to false or am I missing something?

Happy to provide a patch with some rough guidance about what to do here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@julienw