Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video texture provider, texture 2D, ECT needs file extension in the URL in order to work #3918

Open
epicEaston197 opened this issue Jun 28, 2023 · 2 comments
Labels
Tweak Minor tweak

Comments

@epicEaston197
Copy link

Is your tweak request related to a problem? Please describe.

The issue is that if I don't have dot MP4 or some other video file extension at the end of my video URL the video will refuse to load

Describe what would you like tweaked

I would like neos to not require a file extension at the end of URL's because for example if I have a MP4 without dot MP4 in a video player based on context it should know it's a video since it's in a video texture provider

Describe alternatives you've considered

Basically detecting if the URL has dot MP4 at the end if it doesn't insert dot MP4 so the video works

Additional context

I am making a Mastodon viewer and sometimes the URL doesn't have dot MP4 resulting in the video just not loading

@epicEaston197 epicEaston197 added the Tweak Minor tweak label Jun 28, 2023
@epicEaston197 epicEaston197 changed the title Video players need file extension in the URL in order to work Video texture provider, texture 2D, ECT needs file extension in the URL in order to work Jun 28, 2023
@JackTheFoxOtter
Copy link

JackTheFoxOtter commented Jul 2, 2023

There is more video formats / containers than just mp4 out there. You can't assume every resource leads to a .mp4 file just because it's used in the context of the video player. That said, when accessing web resources, usually the type of the resource is specified in the MIME-Type of the response header (for example 'video/mp4' or 'video/webm'). If Neos doesn't already, it could use that to determine what kind of video it is, and choose the corresponding converter if no file extension is present in the URL. This naturally would only work if the correct MIME-Type is specified in the external resource though.

Edit:
Actually, for all web resources it should definitely prioritize the MIME type over a possible file extension in the URL, as that's what web browsers use to determine how a resource should be handled / displayed.
See possible subtypes here:
https://www.iana.org/assignments/media-types/media-types.xhtml#video

@Firepal
Copy link

Firepal commented Jul 12, 2023

MIME types were an afterthought? in a web-centric application which can load files from remote servers? truly amazing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tweak Minor tweak
Projects
None yet
Development

No branches or pull requests

3 participants